Skip to content

enabled and fixed performance-noexcept-move-constructor clang-tidy warnings #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

enabled and fixed performance-noexcept-move-constructor clang-tidy warnings #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ Checks: >
-readability-uppercase-literal-suffix,
-performance-avoid-endl,
-performance-inefficient-string-concatenation,
-performance-no-automatic-move,
-performance-noexcept-move-constructor
-performance-no-automatic-move
HeaderFilterRegex: '.*'
WarningsAsErrors: '*'
CheckOptions:
Expand Down
4 changes: 2 additions & 2 deletions simplecpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ simplecpp::TokenList::TokenList(const TokenList &other) : frontToken(nullptr), b
*this = other;
}

simplecpp::TokenList::TokenList(TokenList &&other) : frontToken(nullptr), backToken(nullptr), files(other.files)
simplecpp::TokenList::TokenList(TokenList &&other) noexcept : frontToken(nullptr), backToken(nullptr), files(other.files)
{
*this = std::move(other);
}
Expand All @@ -521,7 +521,7 @@ simplecpp::TokenList &simplecpp::TokenList::operator=(const TokenList &other)
return *this;
}

simplecpp::TokenList &simplecpp::TokenList::operator=(TokenList &&other)
simplecpp::TokenList &simplecpp::TokenList::operator=(TokenList &&other) noexcept
{
if (this != &other) {
clear();
Expand Down
4 changes: 2 additions & 2 deletions simplecpp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,10 @@ namespace simplecpp {
/** generates a token list from the given filename parameter */
TokenList(const std::string &filename, std::vector<std::string> &filenames, OutputList *outputList = nullptr);
TokenList(const TokenList &other);
TokenList(TokenList &&other);
TokenList(TokenList &&other) noexcept;
~TokenList();
TokenList &operator=(const TokenList &other);
TokenList &operator=(TokenList &&other);
TokenList &operator=(TokenList &&other) noexcept;

void clear();
bool empty() const {
Expand Down