refs #424 - do not store reference to filelist in simplecpp::Location / added simplecpp::TokenList::file() / cleanups
#573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @glankk |
|
This affects the implementation in Cppcheck. Still working on integrating it. |
firewave
commented
Oct 20, 2025
Comment on lines
-82
to
+86
|
|
||
| Location &operator=(const Location &other) { | ||
| if (this != &other) { | ||
| fileIndex = other.fileIndex; | ||
| line = other.line; | ||
| col = other.col; | ||
| } | ||
| return *this; | ||
| } | ||
| Location &operator=(const Location &other) = default; |
There was a problem hiding this comment.
This was lacking the assignment of files. I have no idea how that could have ever been a valid object - beside the fact that containing a reference is even problematic to begin with.
…ocation` / cleanups
…e from location
firewave
force-pushed
the
toklist-files-3
branch
from
ee3d11c to
29156d6
Compare
|
Should not be merged before we post a release with the MinGW fixes. I also want to get in some preprocessor cleanups on the Cppcheck side first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.