Suggest correct file extension when cropping pdf, djvu and tiff #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was suggesting a .jpg extension for multipage files and keeping the same extension for everything else. However, single page .pdf and .djvu should still have the .jpg extension. Multipage .tiff files should keep .tiff and not be .jpg This was causing upload failures unless the user noticed and changes the extension.
|
@danmichaelo friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was suggesting a .jpg extension for multipage files and keeping the same extension for everything else.
However, single page .pdf and .djvu should still have the .jpg extension. Multipage .tiff files should keep .tiff and not be .jpg
This was causing upload failures unless the user noticed and changes the extension.
Some examples of affected files: File:adrenaline_ampoule.pdf or File:1898_circa_Willy_Hoehl_Gruss_vom_Nordstädter_Gesellschaftshaus_Gustav_Fischer,_Oberstraße_7_und_8,_Adressseite.tif