feat: S3 support path style urls#10472
Open
darthhexx wants to merge 10 commits intodanny-avila:mainfrom
Open
Conversation
0888f3d to
65d6180
Compare
0792ae8 to
37014c7
Compare
050ec8a to
c0e0fa9
Compare
306932d to
af03105
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the
forcePathStyleAWS S3 option via a newAWS_FORCE_PATH_STYLEenvironment variable. This allows configuring path-based access to AWS and non-AWS S3 services.Fixes #10276 #11806
Change Type
Please delete any irrelevant options.
Testing
Tested locally using minio, a custom S3 service, and we are running this in production in daily use by 1000+ users.
Checklist
Please delete any irrelevant options.