-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat: add hide "base" models flag to model spec #10915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added hideBaseModels prop to conditionally render endpoint models based on specs.
Add comments for modelSpecs configuration options
Contributor
Author
|
@danny-avila this is ready for review! |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
Adds a new
hideBaseModelsconfiguration option to model specs that allows hiding base/raw models from the model selector when model specs are defined for an endpoint.Related Discussion: #10220 (reply in thread)
Documentation PR: LibreChat-AI/librechat.ai#465
Problem
When using
modelSpecsto provide preconfigured models (e.g., a "gpt-5-codex" with specific settings like Responses API enabled), both the model spec AND the base model appear in the selector. This creates confusion:Solution
This PR implements the
hideBaseModelsoption suggested in the discussion:When
hideBaseModels: trueis set, base models are hidden only for endpoints that have model specs defined. Endpoints without any specs will continue to show their models normally.Change Type
Implementation
hideBaseModelsboolean to thespecsConfigSchema(defaults tofalse)hideBaseModelsistrueand the endpoint has specs definedlibrechat.example.yamlTesting
Unit Tests
Tests verify:
hideBaseModelsdefaults tofalsewhen not providedhideBaseModels: trueis acceptedhideBaseModels: falseis acceptedManual Testing
hideBaseModels: false(or omit) → Base models show as normal alongside specshideBaseModels: truewith specs for an endpoint → Only specs are shown, base models hiddenhideBaseModels: truefor endpoint with NO specs → Base models still shown (no specs to replace them)Checklist