⚖️ feat: Aria-Sort Attributes for Shared Links and Archived Chats DataTables#10985
Closed
dustinhealy wants to merge 1 commit intodev-stagingfrom
Closed
⚖️ feat: Aria-Sort Attributes for Shared Links and Archived Chats DataTables#10985dustinhealy wants to merge 1 commit intodev-stagingfrom
dustinhealy wants to merge 1 commit intodev-stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves accessibility in the
DataTablecomponent by adding proper ARIA attributes to table header cells that indicate the current sort order. This was already implemented in My Files, but Archived Chats and Shared Links use a separateDataTablecomponent so this pull request provides parity between the components for this accessibility feature.Accessibility improvements:
DataTable.tsx, added logic to set thearia-sortattribute on eachTableHeadcell based on the column's sort state, using'ascending'or'descending'as appropriate. This helps screen readers convey the sort order to users. [1] [2]Change Type
Testing
Tests pending (Can't verify sorts are being read out properly with VoiceOver)
Checklist