Skip to content

⚖️ feat: Aria-Sort Attributes for Shared Links and Archived Chats DataTables#10985

Closed
dustinhealy wants to merge 1 commit intodev-stagingfrom
fix/archived-chats-shared-links-datatable
Closed

⚖️ feat: Aria-Sort Attributes for Shared Links and Archived Chats DataTables#10985
dustinhealy wants to merge 1 commit intodev-stagingfrom
fix/archived-chats-shared-links-datatable

Conversation

@dustinhealy
Copy link
Collaborator

Summary

This pull request improves accessibility in the DataTable component by adding proper ARIA attributes to table header cells that indicate the current sort order. This was already implemented in My Files, but Archived Chats and Shared Links use a separate DataTable component so this pull request provides parity between the components for this accessibility feature.

Accessibility improvements:

  • In DataTable.tsx, added logic to set the aria-sort attribute on each TableHead cell based on the column's sort state, using 'ascending' or 'descending' as appropriate. This helps screen readers convey the sort order to users. [1] [2]

Change Type

  • New feature (non-breaking change which adds functionality)

Testing

Tests pending (Can't verify sorts are being read out properly with VoiceOver)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@danny-avila danny-avila deleted the branch dev-staging January 8, 2026 17:23
@danny-avila danny-avila closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants