Skip to content

Conversation

@dustinhealy
Copy link
Collaborator

Summary

This pull request improves the login form user experience and email validation logic. The main changes include enhanced email field validation, dynamic label/placeholder behavior for the email input, and an update to the localization files.

Login form improvements:

  • Replaced the static regex pattern for email validation with the Zod-based validateEmail utility function for more robust and maintainable validation logic. [1] [2]
  • Enhanced the email input label to dynamically show either a placeholder or the full label depending on focus or whether the field has content, improving usability and clarity. [1] [2]

Localization updates:

  • Added a new localization string com_auth_email_placeholder with the value "email@example.com" to support the improved placeholder behavior.

Change Type

  • New feature (non-breaking change which adds functionality)

Testing

Before

Screen.Recording.2025-12-19.at.11.58.29.AM.mov

After

Screen.Recording.2025-12-19.at.11.58.03.AM.mov

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@dustinhealy dustinhealy marked this pull request as draft December 23, 2025 06:34
@dustinhealy
Copy link
Collaborator Author

Closed after feedback from accessibility team, more focused PR opened in #11434 to address cited Axe Issue #501.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant