🔬 ci: Add TypeScript Type Checks to Backend Workflow and Fix All Type Errors

[danny-avila]

Summary

I added a tsc --noEmit type-check job to the backend review CI workflow and fixed all ~180 TypeScript type errors across the four workspace packages. Previously, type errors could slip through CI because the only TypeScript validation came implicitly through rollup builds, which are more lenient than strict tsc checking.

• Add a typecheck job to backend-review.yml that runs tsc --noEmit on data-provider, data-schemas, @librechat/api, and @librechat/client after the build step
• Fix ConfigSection type derivation by replacing broken z import from data-provider with TCustomConfig-based derivation
• Add _id: Types.ObjectId to IUser interface, consistent with other Document types (IAclEntry, IGroup, etc.)
• Add missing federatedTokens and openidTokens optional fields to IUser
• Type untyped mongoose.models.* accessors as Model<IRole> and Model<IUser> instead of relying on unsafe casts
• Import DailyRotateFile constructor directly instead of relying on broken winston module augmentation caused by mismatched node_modules trees
• Fix getUserPrincipals return type to use PrincipalType enum instead of string
• Widen getPremiumRate parameter to accept number | null matching its runtime behavior
• Resolve 110+ test file type errors across 15 spec files using proper typing: ObjectId-typed mock IDs, correct enum values, non-null assertions for test-guaranteed data, and typed mock request objects
• Fix OGDialogTemplate destructuring defaults and remove broken ExtendedFile import in FileIcon

Change Type

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Testing

Verified all four workspaces pass tsc --noEmit with zero errors:

=== data-provider === PASS
=== data-schemas === PASS
=== packages/api === PASS
=== packages/client === PASS

Confirmed tsc exits with code 2 and surfaces error output when a type error is introduced, ensuring the CI job will properly fail and block the PR.

Rebased onto latest dev (including the tenant isolation PR) and re-verified all checks pass after conflict resolution.

Test Configuration:

• Node.js: 20.19
• TypeScript: workspace-local versions
• OS: Windows (dev), Ubuntu (CI target)

Checklist

• My code adheres to this project's style guidelines
• I have performed a self-review of my own code
• My changes do not introduce new warnings
• I have written tests demonstrating that my changes are effective or that my feature works
• Local unit tests pass with my changes

[Copilot]

Pull request overview

Adds explicit TypeScript type-checking to backend PR CI and resolves the resulting TS errors across the monorepo packages (schemas, API, client package, and tests), primarily by tightening types and adjusting test mocks to match runtime shapes.

Changes:

• Add a dedicated tsc --noEmit “typecheck” job to backend-review.yml after build artifacts are produced.
• Fix/align core typings (e.g., IUser, principal typing, model typing, config section typing) to satisfy strict tsc.
• Update numerous tests/mocks to use correct ObjectId/enums/nullability and fix a few runtime typings (winston rotate transport import, Redis scan iterator typing, etc.).

Reviewed changes

Copilot reviewed 38 out of 39 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/data-schemas/src/types/user.ts	Align IUser with ObjectId _id and add OIDC token fields.
packages/data-schemas/src/types/admin.ts	Re-derive ConfigSection from TCustomConfig instead of z/configSchema imports.
packages/data-schemas/src/migrations/tenantIndexes.ts	Add non-null assertion for connection.db.
packages/data-schemas/src/migrations/tenantIndexes.spec.ts	Adjust mongoose db typing to satisfy strict null checks.
packages/data-schemas/src/migrations/promptGroupIndexes.ts	Add non-null assertion for connection.db.
packages/data-schemas/src/methods/userGroup.ts	Type principalType as PrincipalType enum in return values.
packages/data-schemas/src/methods/userGroup.spec.ts	Update assertions to match ObjectId _id typing.
packages/data-schemas/src/methods/user.ts	Type mongoose model access + adjust lean() return typing and scoring map.
packages/data-schemas/src/methods/user.test.ts	Fix mock user _id to be an ObjectId.
packages/data-schemas/src/methods/tx.ts	Widen getPremiumRate arg to accept null.
packages/data-schemas/src/methods/spendTokens.spec.ts	Add non-null assertions to match nullable result shapes.
packages/data-schemas/src/methods/role.ts	Type mongoose Role model accessor as Model<IRole>.
packages/data-schemas/src/methods/role.methods.spec.ts	Add non-null assertions / cast records for permission map access.
packages/data-schemas/src/methods/config.spec.ts	Update config payloads to match typed config structure.
packages/data-schemas/src/methods/aclEntry.ts	Relax bulk write op typing to satisfy TS.
packages/data-schemas/src/config/winston.ts	Import DailyRotateFile directly and instantiate transport.
packages/data-schemas/src/config/meiliLogger.ts	Import DailyRotateFile directly and instantiate transport.
packages/data-schemas/package.json	Add winston-daily-rotate-file to devDependencies for local builds/tests.
packages/client/src/svgs/FileIcon.tsx	Remove ExtendedFile dependency and type progress explicitly.
packages/client/src/components/OGDialogTemplate.tsx	Fix destructuring defaults for legacy/non-legacy selection props.
packages/api/src/utils/sanitizeTitle.spec.ts	Add local global typing for String.prototype.isWellFormed.
packages/api/src/utils/oidc.spec.ts	Switch test user type from data-provider TUser to schemas IUser.
packages/api/src/utils/graph.spec.ts	Switch test user type to IUser and clean up mock typing.
packages/api/src/utils/env.ts	Type federatedTokens on safe user object more precisely.
packages/api/src/middleware/preAuthTenant.spec.ts	Type req mock more precisely (headers/ip/path).
packages/api/src/middleware/capabilities.ts	Update injected getUserPrincipals signature to match new typing.
packages/api/src/mcp/registry/cache/tests/ServerConfigsCacheRedisAggregateKey.cache_integration.spec.ts	Adjust spy call assertions to satisfy TS typing.
packages/api/src/mcp/registry/cache/tests/ServerConfigsCacheRedis.perf_benchmark.manual.spec.ts	Type Redis client for scanIterator usage.
packages/api/src/mcp/tests/MCPOAuthTokenStorage.test.ts	Align clientInfo test objects with expected shape.
packages/api/src/mcp/tests/MCPOAuthSecurity.test.ts	Mock fetch with required preconnect field for type compatibility.
packages/api/src/mcp/tests/MCPOAuthFlow.test.ts	Use TokenExchangeMethodEnum and tighten flow result typing.
packages/api/src/endpoints/custom/initialize.spec.ts	Adjust request body mocks to satisfy request typing.
packages/api/src/cache/tests/redisClients.cache_integration.spec.ts	Remove any in catches; cast to Error for message access.
packages/api/src/cache/tests/cacheFactory/sessionCache.cache_integration.spec.ts	Type session store union and bridge to test data shape.
packages/api/src/auth/openid.spec.ts	Update mocked users to use ObjectId _id.
packages/api/src/app/service.spec.ts	Introduce TestConfig helper type for mock-only fields in config tests.
packages/api/src/admin/config.handler.spec.ts	Strongly type request/response mocks and body assertions.
package-lock.json	Lockfile updates for dependency/version changes.
.github/workflows/backend-review.yml	Add typecheck job running tsc --noEmit across workspaces.

Comments suppressed due to low confidence (1)

packages/data-schemas/src/methods/aclEntry.ts:382

• Changing bulkWriteAclEntries from AnyBulkWriteOperation<IAclEntry>[] to the non-generic AnyBulkWriteOperation[] removes schema-level type checking for bulk ops, making it easy to pass operations that don’t match the AclEntry model shape. If the generic was causing a TS mismatch, consider narrowing with AnyBulkWriteOperation<IAclEntry>[] (or a small wrapper/alias) rather than dropping the type parameter entirely.

  async function bulkWriteAclEntries(
    ops: AnyBulkWriteOperation[],
    options?: { session?: ClientSession },
  ) {
    const AclEntry = mongoose.models.AclEntry as Model<IAclEntry>;
    return tenantSafeBulkWrite(AclEntry, ops, options || {});

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[danny-avila]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".