fix: Daily note integration uses meeting date instead of sync date

[georgeguimaraes]

When a meeting syncs after its creation date (e.g., a Tuesday meeting syncs on Wednesday), the daily note link currently gets added to today's note instead of the meeting's actual date. This is because syncDocuments filters with noteDate === today.

This PR groups synced notes by their created_at date and updates the corresponding daily/periodic note for each date independently. A Friday meeting that syncs on Monday will now correctly link in Friday's daily note.

Changes:

• syncDocuments: groups notes by creation date instead of filtering for today
• updateDailyNote/updatePeriodicNote: accept a date parameter
• getDailyNote/getPeriodicNote: accept a date parameter instead of hardcoding new Date()

[Copilot]

Pull request overview

This PR fixes a bug where synced meetings were being added to today's daily note instead of the note corresponding to the meeting's creation date. The fix groups meetings by their created_at date and updates each date's daily/periodic note independently.

Changes:

• Modified syncDocuments to group notes by creation date instead of filtering for today
• Added date parameter to updateDailyNote, updatePeriodicNote, getDailyNote, and getPeriodicNote methods
• Refactored the daily/periodic note update logic to process each date group separately

Comments suppressed due to low confidence (1)

main.js:1550

• The variable possibleDailyNotes in the getPeriodicNote method should be renamed to possiblePeriodicNotes to accurately reflect that it's searching for periodic notes, not daily notes. This improves code clarity and reduces confusion.

			const possibleDailyNotes = files.filter(file => {
				if (file.name === formatted + '.md' || file.name === formatted) {
					return true;
				}
				if (file.path.includes('Daily') && (file.name.includes(formatted) || file.path.includes(formatted))) {
					return true;
				}
				return file.name.includes(formatted) ||
					   file.path.includes(formatted) ||
					   file.name.includes(targetDate.toDateString().split(' ')[2]) ||
					   file.name.includes(targetDate.getDate().toString());
			});

			possibleDailyNotes.sort((a, b) => {
				if (a.name === formatted + '.md' || a.name === formatted) return -1;
				if (b.name === formatted + '.md' || b.name === formatted) return 1;
				if (a.path.includes('Daily') && !b.path.includes('Daily')) return -1;
				if (b.path.includes('Daily') && !a.path.includes('Daily')) return 1;
				return 0;
			});
			
			// Return the first match
			if (possibleDailyNotes.length > 0) {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The comment "Let's try to find the daily note directly" is misleading in the getPeriodicNote method. It should say "periodic note" instead of "daily note" to accurately reflect the method's purpose.

Suggested change

	// Let's try to find the daily note directly by looking for it in the vault
	// Let's try to find the periodic note directly by looking for it in the vault

[Copilot]

Potential timezone issue: Using toDateString() as the key (line 333) and then using the same date object for updates may cause issues if meetings are created near midnight. The toDateString() method converts to local time, which means a meeting created at 23:59 UTC on Tuesday could appear as Wednesday in some timezones. Consider whether the grouping should use UTC dates or if the current behavior is intentional to match user's local timezone.

Suggested change

	const dateKey = createdDate.toDateString();
	const dateKey = createdDate.toISOString().slice(0, 10); // Use UTC date (YYYY-MM-DD) as stable key

[Copilot]

Consider adding a length check before accessing array elements. While the loop over Object.entries(notesByDate) will skip empty objects, and theoretically arrays shouldn't be empty in this structure, defensive programming suggests checking notes.length > 0 before accessing notes[0].date to prevent potential runtime errors.

Suggested change

	for (const [dateKey, notes] of Object.entries(notesByDate)) {
	for (const [dateKey, notes] of Object.entries(notesByDate)) {
	// Defensive check: ensure there is at least one note before accessing notes[0]
	if (!notes || notes.length === 0) {
	continue;
	}

[Copilot]

The getPeriodicNote method is searching for files in paths containing 'Daily' (lines 1532, 1544-1545), but this should be searching for periodic notes, not daily notes. This appears to be a logic error that would cause the method to look in the wrong location for periodic notes. Consider updating the search logic to look for periodic note patterns or use a more appropriate folder name.

[Copilot]

Consider validating that createdDate is a valid date after parsing. If doc.created_at contains an invalid date string, new Date(doc.created_at) will create an Invalid Date object, and toDateString() will return "Invalid Date", which could cause all invalid dates to be grouped together. Consider adding a check like !isNaN(createdDate.getTime()) before using the date.

Suggested change

	const dateKey = createdDate.toDateString();
	// Find the actual file that was created or already exists
	const actualFile = await this.findExistingNoteByGranolaId(doc.id);
	if (actualFile) {
	const noteData = {};
	noteData.title = doc.title || 'Untitled Granola Note';
	noteData.actualFilePath = actualFile.path;
	noteData.date = createdDate;
	const hours = String(createdDate.getHours()).padStart(2, '0');
	const minutes = String(createdDate.getMinutes()).padStart(2, '0');
	noteData.time = hours + ':' + minutes;
	if (!notesByDate[dateKey]) {
	notesByDate[dateKey] = [];
	}
	notesByDate[dateKey].push(noteData);
	if (!isNaN(createdDate.getTime())) {
	const dateKey = createdDate.toDateString();
	// Find the actual file that was created or already exists
	const actualFile = await this.findExistingNoteByGranolaId(doc.id);
	if (actualFile) {
	const noteData = {};
	noteData.title = doc.title || 'Untitled Granola Note';
	noteData.actualFilePath = actualFile.path;
	noteData.date = createdDate;
	const hours = String(createdDate.getHours()).padStart(2, '0');
	const minutes = String(createdDate.getMinutes()).padStart(2, '0');
	noteData.time = hours + ':' + minutes;
	if (!notesByDate[dateKey]) {
	notesByDate[dateKey] = [];
	}
	notesByDate[dateKey].push(noteData);
	}