Skip to content

fix: support nested Granola folders in folder-based path generation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaeljauk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: support nested Granola folders in folder-based path generation #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,12 @@ class GranolaSyncPlugin extends obsidian.Plugin {
if (folders) {
// Create a mapping of document ID to folder for quick lookup
this.documentToFolderMap = {};
// Create a mapping of folder ID to folder for parent traversal
this.folderIdMap = {};
// Also store all available folders for the settings UI
this.availableGranolaFolders = folders;
for (const folder of folders) {
this.folderIdMap[folder.id] = folder;
if (folder.document_ids) {
for (const docId of folder.document_ids) {
this.documentToFolderMap[docId] = folder;
Expand Down Expand Up @@ -760,13 +763,24 @@ class GranolaSyncPlugin extends obsidian.Plugin {
return this.settings.syncDirectory;
}

// Clean folder name for filesystem use
const cleanFolderName = folder.title
// Build the full folder path by traversing parent_document_list_id chain
const cleanName = (title) => title
.replace(/[<>:"/\\|?*]/g, '') // Remove invalid filesystem characters
.replace(/\s+/g, this.settings.filenameSeparator) // Replace spaces with configured separator
.trim();

return path.join(this.settings.syncDirectory, cleanFolderName);
const segments = [];
let current = folder;
const visited = new Set();
while (current) {
if (visited.has(current.id)) break; // guard against cycles
visited.add(current.id);
segments.unshift(cleanName(current.title));
const parentId = current.parent_document_list_id;
current = (parentId && this.folderIdMap) ? this.folderIdMap[parentId] : null;
}

return path.join(this.settings.syncDirectory, ...segments);
}

async ensureDateBasedDirectoryExists(datePath) {
Expand Down Expand Up @@ -2006,7 +2020,10 @@ class GranolaSyncPlugin extends obsidian.Plugin {
if (folders) {
// Create a mapping of document ID to folder for quick lookup
this.documentToFolderMap = {};
// Create a mapping of folder ID to folder for parent traversal
this.folderIdMap = {};
for (const folder of folders) {
this.folderIdMap[folder.id] = folder;
if (folder.document_ids) {
for (const docId of folder.document_ids) {
this.documentToFolderMap[docId] = folder;
Expand Down