Translate chinese Comments and Logs in lib to english#110
Open
luis-kueng wants to merge 2 commits intodaodao97:mainfrom
Open
Translate chinese Comments and Logs in lib to english#110luis-kueng wants to merge 2 commits intodaodao97:mainfrom
luis-kueng wants to merge 2 commits intodaodao97:mainfrom
Conversation
Owner
|
Thank you for your contribution. This is indeed a problem for non-Chinese native programmers. The project is updated very frequently. There are some conflicts now. I have to trouble you to update the latest code before merging. |
Author
|
Thank you for the review and feedback! I see the conflicts and will update the PR later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that comments and logs are inconsistently written either in English or Chinese. As this makes it hard for non-chinese speaking developers to contribute, I decided to translate everything in /lib/ to english.
I would totally understand if this is not a desired change. As I already spent the time, I will still open a PR.
I can't guarantee the correctness of every translation. All translations have been made using AI.