Skip to content

Restore dart format checks #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Restore dart format checks #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d9fcdc
Restore `dart format` checks
daohoangson Feb 18, 2025
3bbe9b0
Print Dart version
daohoangson Feb 18, 2025
a17529f
Move `dart format` check into `./tool/test.sh`
daohoangson Feb 19, 2025
2b3a4e0
Merge remote-tracking branch 'origin/master' into fix/dart-format
daohoangson Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/flutter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ jobs:
uses: subosito/flutter-action@e938fdf56512cc96ef2f93601a5a40bde3801046 # v2.19.0
with:
cache: true

# TODO: investigate why this fail on GitHub Actions
# - run: dart format --set-exit-if-changed --output none .

- name: Run chromedriver
run: |
set -e
Expand Down
9 changes: 9 additions & 0 deletions tool/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,23 @@ set -euo pipefail

(
cd ./packages/core &&
dart format --set-exit-if-changed --output none . &&
flutter analyze &&
flutter test "$@" &&
echo 'packages/core OK'
)

(
cd ./packages/fwfh_just_audio &&
dart format --set-exit-if-changed --output none . &&
flutter analyze &&
flutter test "$@" &&
echo 'packages/fwfh_just_audio OK'
)

(
cd ./packages/fwfh_svg &&
dart format --set-exit-if-changed --output none . &&
flutter analyze &&
flutter test "$@" &&
echo 'packages/fwfh_svg OK'
Expand All @@ -27,27 +30,31 @@ if [ -z ${UPDATE_GOLDENS+x} ]; then
# UPDATE_GOLDENS is unset, run all packages
(
cd ./packages/fwfh_cached_network_image &&
dart format --set-exit-if-changed --output none . &&
flutter analyze &&
flutter test "$@" &&
echo 'packages/fwfh_cached_network_image OK'
)

(
cd ./packages/fwfh_chewie &&
dart format --set-exit-if-changed --output none . &&
flutter analyze &&
flutter test "$@" &&
echo 'packages/fwfh_chewie OK'
)

(
cd ./packages/fwfh_url_launcher &&
dart format --set-exit-if-changed --output none . &&
flutter analyze &&
flutter test "$@" &&
echo 'packages/fwfh_url_launcher OK'
)

(
cd ./packages/fwfh_webview &&
dart format --set-exit-if-changed --output none . &&
flutter analyze &&
flutter test "$@" &&
echo 'packages/fwfh_webview OK'
Expand All @@ -66,6 +73,7 @@ if [ -z ${UPDATE_GOLDENS+x} ]; then

(
cd ./packages/enhanced &&
dart format --set-exit-if-changed --output none . &&
flutter analyze &&
flutter test "$@" &&
echo 'packages/enhanced OK'
Expand All @@ -74,6 +82,7 @@ fi

(
cd ./demo_app &&
dart format --set-exit-if-changed --output none . &&
flutter analyze &&
flutter test "$@" &&
echo 'demo_app OK'
Expand Down
Loading