Skip to content

Fix lint warnings #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Fix lint warnings #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo_app/lib/screens/wordpress.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ class _PostsState extends State<_PostsList> {
);
}

List<_Post> _parseJson(json) {
List<_Post> _parseJson(dynamic json) {
final posts = <_Post>[];
if (json is List) {
for (final postJson in json) {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/test/core_config_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ void main() {
_OnTapUrlApp(
href: href,
onTapCallbackResults: onTapCallbackResults,
onTapUrl: (_) async => false,
onTapUrl: (_) => false,
),
);
await tester.pumpAndSettle();
Expand All @@ -539,7 +539,7 @@ void main() {
_OnTapUrlApp(
href: href,
onTapCallbackResults: onTapCallbackResults,
onTapUrl: (_) async => true,
onTapUrl: (_) => true,
),
);
await tester.pumpAndSettle();
Expand Down
2 changes: 1 addition & 1 deletion packages/enhanced/test/_.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Future<String> explain(
Widget? hw,
GlobalKey? key,
bool useExplainer = true,
}) async {
}) {
key ??= helper.hwKey;
return helper.explain(
tester,
Expand Down
4 changes: 2 additions & 2 deletions packages/enhanced/test/config_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ void main() {
tester,
HtmlWidget(
'<a href="$href">Tap me</a>',
onTapUrl: (url) async {
onTapUrl: (url) {
urls.add(url);
return false;
},
Expand All @@ -529,7 +529,7 @@ void main() {
tester,
HtmlWidget(
'<a href="$href">Tap me</a>',
onTapUrl: (url) async {
onTapUrl: (url) {
urls.add(url);
return true;
},
Expand Down
2 changes: 1 addition & 1 deletion packages/fwfh_just_audio/test/_.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Future<String> explain(
WidgetTester tester,
String html, {
bool useExplainer = true,
}) async =>
}) =>
helper.explain(
tester,
null,
Expand Down
2 changes: 1 addition & 1 deletion packages/fwfh_svg/test/_.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Future<String> explain(
WidgetTester tester,
String html, {
bool useExplainer = true,
}) async =>
}) =>
helper.explain(
tester,
null,
Expand Down
2 changes: 1 addition & 1 deletion packages/fwfh_url_launcher/test/_.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import '../../core/test/_.dart' as helper;

const tapText = helper.tapText;

Future<String> explain(WidgetTester tester, String html) async =>
Future<String> explain(WidgetTester tester, String html) =>
helper.explain(
tester,
null,
Expand Down
2 changes: 1 addition & 1 deletion packages/fwfh_webview/test/_.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Future<String> explain(
String html, {
Uri? baseUrl,
bool useExplainer = true,
}) async =>
}) =>
helper.explain(
tester,
null,
Expand Down
2 changes: 1 addition & 1 deletion packages/fwfh_webview/test/mock_webview_platform.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ abstract class FakeWebViewController extends PlatformWebViewController {
FutureOr<NavigationDecision?> onNavigationRequest({
required String url,
required bool isMainFrame,
}) async {
}) {
final req = NavigationRequest(url: url, isMainFrame: isMainFrame);
return _handler?._onNavigationRequest?.call(req);
}
Expand Down