Skip to content

Fix SonarCloud code smells #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Fix SonarCloud code smells #1433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions packages/core/lib/src/internal/parser/color.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,17 @@ CssColor? tryParseColor(css.Expression? expression) {
return null;
}

double? _parseColorAlpha(css.Expression v) => (v is css.NumberTerm
? v.number.toDouble()
: v is css.PercentageTerm
? v.valueAsDouble
: null)
?.clamp(0.0, 1.0);
double? _parseColorAlpha(css.Expression expression) {
final double? value;
if (expression is css.NumberTerm) {
value = expression.number.toDouble();
} else if (expression is css.PercentageTerm) {
value = expression.valueAsDouble;
} else {
value = null;
}
return value?.clamp(0, 1);
}

double _parseColorHue(num number, [int? unit]) {
final v = number is double ? number : number.toDouble();
Expand All @@ -122,12 +127,17 @@ double _parseColorHue(num number, [int? unit]) {
return deg % 360;
}

int? _parseColorRgbElement(css.Expression v) => (v is css.NumberTerm
? v.number.ceil()
: v is css.PercentageTerm
? (v.valueAsDouble * 255.0).ceil()
: null)
?.clamp(0, 255);
int? _parseColorRgbElement(css.Expression expression) {
final int? value;
if (expression is css.NumberTerm) {
value = expression.number.ceil();
} else if (expression is css.PercentageTerm) {
value = (expression.valueAsDouble * 255.0).ceil();
} else {
value = null;
}
return value?.clamp(0, 255);
}

String _x2(String value) {
final sb = StringBuffer();
Expand Down