Skip to content

Add support for [email protected] #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 14, 2025
Merged

Add support for [email protected] #1448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d23e32
Update dependency just_audio to <0.11.0
renovate[bot] May 13, 2025
dfeb546
Expand version range
Jul 13, 2025
d11c036
Fix audio_player_test.dart
Jul 13, 2025
be777dd
Create mock_just_audio_platform.dart
Jul 13, 2025
1ab586d
Clean up mock_just_audio_platform.dart
Jul 13, 2025
a284ff1
Clean up PR
Jul 13, 2025
970da72
Merge remote-tracking branch 'origin/master' into renovate/just_audio…
daohoangson Jul 14, 2025
102da5c
fwfh_just_audio now requires [email protected], [email protected]
daohoangson Jul 14, 2025
d68c6b5
[skip ci] Clean up PR
daohoangson Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/fwfh_just_audio/lib/src/audio_player/audio_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,8 @@ class _AudioPlayerState extends State<AudioPlayer> {
final theme = Theme.of(context);
final fontSize = DefaultTextStyle.of(context).style.fontSize ?? 14.0;

// TODO: remove lint ignore when our minimum Flutter version >= 3.16
// ignore: deprecated_member_use
final tsf = MediaQuery.textScaleFactorOf(context);
final iconSize = fontSize * tsf;
final tsf = MediaQuery.textScalerOf(context);
final iconSize = tsf.scale(fontSize);

return DecoratedBox(
decoration: BoxDecoration(
Expand Down Expand Up @@ -191,10 +189,7 @@ class _PositionText extends StatelessWidget {
return Text(
text,
style: TextStyle(fontSize: size),

// TODO: remove lint ignore when our minimum Flutter version >= 3.16
// ignore: deprecated_member_use
textScaleFactor: 1,
textScaler: TextScaler.noScaling,
);
},
stream: positionStream,
Expand Down
9 changes: 5 additions & 4 deletions packages/fwfh_just_audio/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ description: WidgetFactory extension to render AUDIO with the just_audio plugin.
homepage: https://github.com/daohoangson/flutter_widget_from_html

environment:
flutter: ">=3.10.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.27.0"
sdk: ">=3.6.0 <4.0.0"

dependencies:
flutter:
sdk: flutter
flutter_widget_from_html_core: ">=0.8.0 <0.17.0"
just_audio: ">=0.9.0 <0.10.0"
just_audio: ^0.10.4

dependency_overrides:
flutter_widget_from_html_core:
Expand All @@ -21,8 +21,9 @@ dev_dependencies:
flutter_test:
sdk: flutter
golden_toolkit: ^0.15.0
just_audio_platform_interface: ">=4.0.0 <5.0.0"
just_audio_platform_interface: ^4.5.0
lint: any
plugin_platform_interface: any
tuple: any

flutter:
Expand Down
Loading