Skip to content

Fix flower.mp4 URLs #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2025
Merged

Fix flower.mp4 URLs #1454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4124f6
Fix flower.mp4 URLs
daohoangson Apr 19, 2025
578192c
Update goldens
Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo_app/integration_test/auto_resize_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ void main() {
patrolTest('VideoPlayer', ($) async {
final test = _AspectRatioTest(
child: VideoPlayer(
'https://files.daohoangson.com/public/fwfh/flower.mp4',
'https://flutter-widget-from-html.github.io/pages/flower.mp4',
aspectRatio: 1,
loadingBuilder: (_, __, ___) =>
const Center(child: CircularProgressIndicator()),
Expand Down
2 changes: 1 addition & 1 deletion demo_app/lib/screens/hello_world.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ const kHtml = '''
<h4>&lt;VIDEO&gt;</h4>
<figure>
<video controls width="250">
<source src="https://files.daohoangson.com/public/fwfh/flower.mp4" type="video/mp4">
<source src="https://flutter-widget-from-html.github.io/pages/flower.mp4" type="video/mp4">
<code>VIDEO</code> support is not enabled.
</video>
<figcaption>Source: <a href="https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video">developer.mozilla.org</a></figcaption>
Expand Down
2 changes: 1 addition & 1 deletion demo_app/lib/screens/video.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class _State extends State<VideoScreen> {
_html,
key: Key(_html),
baseUrl: Uri.parse(
'https://files.daohoangson.com/public/fwfh/',
'https://flutter-widget-from-html.github.io/pages/',
),
),
),
Expand Down
2 changes: 1 addition & 1 deletion demo_app/test/goldens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"U": "This is an <u>underline</u> text.",
"UL": "<ul>\n <li>One</li>\n <li>\n Two\n <ul>\n <li>2.1</li>\n <li>\n 2.2\n <ul>\n <li>2.2.1</li>\n <li>2.2.2</li>\n <li>2.2.3</li>\n </ul>\n </li>\n <li>2.3</li>\n </ul>\n </li>\n <li>Three</li>\n</ul>",
"VAR": "<var>x</var> = 1",
"VIDEO": "<video controls width=\"250\">\n <source src=\"https://files.daohoangson.com/public/fwfh/flower.mp4\" type=\"video/mp4\">\n <code>VIDEO</code> support is not enabled.\n</video>",
"VIDEO": "<video controls width=\"250\">\n <source src=\"https://flutter-widget-from-html.github.io/pages/flower.mp4\" type=\"video/mp4\">\n <code>VIDEO</code> support is not enabled.\n</video>",
"attribute/align/center": "<div align=\"center\">Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut non elementum quam. Suspendisse odio diam, maximus pellentesque nunc a, pulvinar facilisis erat. Vivamus a viverra sem. Vivamus vehicula nibh mi, quis ornare orci laoreet vitae. Maecenas sagittis rutrum nisl nec dignissim. Suspendisse cursus est ut ultrices volutpat. Cras vel vestibulum arcu. Curabitur eget molestie nunc. Quisque fringilla quam vitae rhoncus lacinia. Vivamus id laoreet metus. Etiam sed mollis tellus. Vivamus facilisis faucibus libero eu interdum. Pellentesque laoreet magna porta viverra faucibus.</div>",
"attribute/align/left": "<div align=\"left\">Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut non elementum quam. Suspendisse odio diam, maximus pellentesque nunc a, pulvinar facilisis erat. Vivamus a viverra sem. Vivamus vehicula nibh mi, quis ornare orci laoreet vitae. Maecenas sagittis rutrum nisl nec dignissim. Suspendisse cursus est ut ultrices volutpat. Cras vel vestibulum arcu. Curabitur eget molestie nunc. Quisque fringilla quam vitae rhoncus lacinia. Vivamus id laoreet metus. Etiam sed mollis tellus. Vivamus facilisis faucibus libero eu interdum. Pellentesque laoreet magna porta viverra faucibus.</div>",
"attribute/align/right": "<div align=\"right\">Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut non elementum quam. Suspendisse odio diam, maximus pellentesque nunc a, pulvinar facilisis erat. Vivamus a viverra sem. Vivamus vehicula nibh mi, quis ornare orci laoreet vitae. Maecenas sagittis rutrum nisl nec dignissim. Suspendisse cursus est ut ultrices volutpat. Cras vel vestibulum arcu. Curabitur eget molestie nunc. Quisque fringilla quam vitae rhoncus lacinia. Vivamus id laoreet metus. Etiam sed mollis tellus. Vivamus facilisis faucibus libero eu interdum. Pellentesque laoreet magna porta viverra faucibus.</div>",
Expand Down
Binary file modified demo_app/test/goldens/VIDEO.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/fwfh_chewie/example/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class MyApp extends StatelessWidget {
child: HtmlWidget(
'''
<video controls width="250">
<source src="https://files.daohoangson.com/public/fwfh/flower.mp4" type="video/mp4">
<source src="https://flutter-widget-from-html.github.io/pages/flower.mp4" type="video/mp4">
<code>VIDEO</code> support is not enabled.
</video>''',
factoryBuilder: () => MyWidgetFactory(),
Expand Down