Skip to content

Conversation

@daltonbohning
Copy link
Contributor

Give create_release.yml write permission so it can create tags. Also exit on error.

Doc-only: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Give create_release.yml write permission so it can create tags.
Also exit on error.

Doc-only: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Aug 5, 2025
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Ticket title is 'GHA create_release needs write permission'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-17877

Doc-only: true

Signed-off-by: Dalton Bohning <[email protected]>
This reverts commit 034ae0a.

Doc-only: true
Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
Copy link
Contributor Author

This is shown to be working here:
https://github.com/daos-stack/daos/actions/runs/16761556842/job/47457799767

@daltonbohning daltonbohning marked this pull request as ready for review August 5, 2025 21:23
@daltonbohning daltonbohning requested a review from a team as a code owner August 5, 2025 21:23
@daltonbohning daltonbohning requested a review from phender August 5, 2025 21:23
@daltonbohning daltonbohning requested a review from a team August 7, 2025 16:56
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 7, 2025
@daltonbohning
Copy link
Contributor Author

Skipped Jenkins CI since this only affects GHA

@daltonbohning daltonbohning merged commit f0deb01 into master Aug 7, 2025
29 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-17877 branch August 7, 2025 16:57
daltonbohning added a commit that referenced this pull request Aug 8, 2025
Give create_release.yml write permission so it can create tags.
Also exit on error.

Doc-only: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Aug 12, 2025
)

Give create_release.yml write permission so it can create tags.
Also exit on error.

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Development

Successfully merging this pull request may close these issues.

4 participants