DAOS-18487 object: control EC rebuild resource consumption #17442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A degraded EC read will allocate and register an extra buffer to recover data, which may cause ENOMEM in some cases. this workaround does not prevent dynamic buffer allocation and registration, it does provide relatively precise control over the resources consumed by degraded EC reads. Signed-off-by: Liang Zhen <[email protected]>
|
Errors are Unable to load ticket data |
Contributor
Author
|
This is another patch to decrease the chance of running into ENOMEM, because the aurora branch still uses the old resource management which only has 256MB DMA buffer for rebuild, so I decrease the amplification factor to 6, which is 8 for master & 2.6 |
Collaborator
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17442/1/testReport/ |
NiuYawei
previously approved these changes
Jan 26, 2026
wangshilong
previously approved these changes
Jan 26, 2026
liuxuezhao
reviewed
Jan 26, 2026
src/object/srv_obj_migrate.c
Outdated
| * registration, it does provide relatively precise control over the | ||
| * resources consumed by degraded EC reads. | ||
| */ | ||
| data_size *= MIN(6, obj_ec_data_tgt_nr(&mrone->mo_oca)); |
Contributor
There was a problem hiding this comment.
please consider to define a new variable to avoid affect migrate_dkey(), as commented on master PR.
Signed-off-by: Liang Zhen <[email protected]>
wangshilong
approved these changes
Jan 26, 2026
liuxuezhao
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A degraded EC read will allocate and register an extra buffer to recover data, which may cause ENOMEM in some cases.
this workaround does not prevent dynamic buffer allocation and registration, it does provide relatively precise control over the resources consumed by degraded EC reads.
Steps for the author:
After all prior steps are complete: