Connect isSymmetric kernel to DaphneDSL#962
Conversation
- Fixed failing code style CI check by formatting DaphneDSLBuiltins.cpp. - Added the new DaphneDSL built-in function isSymmetric() to the user documentation. - Undid unnecessary changes regarding ValueTypeCode BOOL in ValueTypeCode.h and DaphneInferTypesOpInterface.cpp. - Moved definition of IsSymmetricOp in DaphneOps.td near the other meta-data/property-related ops (NumColsOp, TypeOfOp, etc.). - And some more minor things.
pdamme
left a comment
There was a problem hiding this comment.
Thanks for this contribution, @gghsu! It's great to finally connect the isSymmetric-kernel to DaphneDSL to offer it to users. Your code looks good to me.
I only applied some minor improvements, e.g., formatted the code to make the CI code style checks pass, added the new built-in function to the user documentation, and moved the definition of IsSymmetricOp in DaphneOps.td close to the other meta-data-related ops. Furthermore, your changes related to the ValueTypeCode BOOL were not strictly required for this PR, so I undid them. See the commit I added for details. Nevertheless, these are just minor editorial changes; overall, you did very good work!
Congrats on your first contribution to DAPHNE! It would be great to see more PRs from you in the future :) .
This warning is from inside the ANTLR library. We should fix that at some point (maybe by upgrading to a newer version of ANTLR), but that's not related to this PR :) . |
This pull request addressed Issue #959 by connecting isSymmetric-kernel to DaphneDSL.
To achieve this, I did following modification:
Though it builds successfully and passes all the testcase, there is a warning as below which happens in build process. I think it might due to the new boolean output type, however, I'm not sure how to fix it at this time.
