fix: Enable testing and benchmarking together in Roles pallet#189
Open
fix: Enable testing and benchmarking together in Roles pallet#189
Conversation
Member
TarekkMA
changed the title
TarekkMA
force-pushed
the
tarekkma/fix-roles-warns
branch
from
7e5f0fd to
450fbe3
Compare
F3Joule
requested review from
mckrava and
olehmell
and removed request for
siman
F3Joule
approved these changes
Apr 28, 2023
olehmell
approved these changes
May 10, 2023
F3Joule
added
enhancement
siman
approved these changes
Jan 4, 2024
F3Joule
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed all warnings in the Roles pallet and enable all tests to run with benchmarking enabled.
Using conditional compilation, I provided 2 implementations for
get_dummy_space_idandget_caller_accountdepending on what flags are enabled.CU-861mbd2cd