Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to how Docker Compose files are managed and containers are recreated, focusing on preventing unnecessary container restarts and ensuring accurate detection of configuration changes. The main changes involve removing hardcoded DNS entries, updating test cases, and enhancing the logic for detecting and handling compose file modifications in the
StakerComponent.Compose file management improvements:
ComposeEditorto usedelete service.dnsinstead of setting it toundefined, preventingdns: nullfrom appearing in the YAML and avoiding unnecessary container recreation by Docker Compose.Test updates for DNS removal:
network.test.tsto remove references todns: undefined, aligning tests with the updated compose file logic. [1] [2]StakerComponent enhancements:
StakerComponentto read the compose YAML before and after applying user settings, detect actual changes, and only allow Docker Compose to recreate containers when the file has changed—otherwise, it uses--no-recreateto minimize downtime.fsimport to support reading compose files for change detection.