Rename components directory to resources under .dapr directory
#1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pravin Pushkar <[email protected]>
…to it. Signed-off-by: Pravin Pushkar <[email protected]>
pravinpushkar
changed the title
components directory to resources under .dapr directory
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
+ Coverage 26.11% 26.58% +0.46%
==========================================
Files 38 38
Lines 2604 2656 +52
==========================================
+ Hits 680 706 +26
- Misses 1858 1878 +20
- Partials 66 72 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
shubham1172
reviewed
Dec 12, 2022
akhilac1
suggested changes
Dec 12, 2022
shubham1172
suggested changes
Dec 13, 2022
Co-authored-by: Shubham Sharma <[email protected]> Signed-off-by: Pravin Pushkar <[email protected]>
Co-authored-by: Shubham Sharma <[email protected]> Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
shubham1172
reviewed
Dec 13, 2022
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
shubham1172
reviewed
Dec 14, 2022
shubham1172
reviewed
Dec 14, 2022
shubham1172
reviewed
Dec 29, 2022
shubham1172
reviewed
Dec 29, 2022
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
shubham1172
reviewed
Dec 30, 2022
shubham1172
reviewed
Dec 30, 2022
shubham1172
reviewed
Dec 30, 2022
shubham1172
reviewed
Dec 30, 2022
Signed-off-by: Pravin Pushkar <[email protected]>
shubham1172
previously approved these changes
Jan 2, 2023
Signed-off-by: Pravin Pushkar <[email protected]>
pravinpushkar
force-pushed
the
feat/resources_dir
branch
from
89175d1 to
c5646d4
Compare
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
shubham1172
reviewed
Jan 12, 2023
| if !isSlimMode() && daprContainerRuntime != "" && !utils.Contains(uninstallArgs, "--container-runtime") { | ||
| uninstallArgs = append(uninstallArgs, "--container-runtime", daprContainerRuntime) | ||
| } | ||
| return spawn.Command(common.GetDaprPath(), uninstallArgs...) |
There was a problem hiding this comment.
Why not reuse cmdUninstall, similar to installDapr function above?
shubham1172
reviewed
Jan 12, 2023
Comment on lines
-132
to
-161
| daprContainerRuntime := containerRuntime() | ||
|
|
||
| // Add --container-runtime flag only if daprContainerRuntime is not empty, or overridden via args. | ||
| // This is only valid for non-slim mode. | ||
| if !isSlimMode() && daprContainerRuntime != "" && !utils.Contains(args, "--container-runtime") { | ||
| uninstallArgs = append(uninstallArgs, "--container-runtime", daprContainerRuntime) | ||
| } |
There was a problem hiding this comment.
Why did we remove this instead of moving it to cmdUninstall and using this instead of the new function in utils?
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@pravinpushkar Please fix conflicts in this PR. @msfussell @yaron2 I think this PR can go in 1.11. (Renaming default |
Signed-off-by: Pravin Pushkar <[email protected]>
Signed-off-by: Pravin Pushkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dapr initbehaviour to createresourcesdir instead ofcomponentsand then creates a symlinkcomponentsforresourcesdirectory.componentsdir,dapr initwill also moves its contents intoresourcesdir, deletes thecomponentsdirectory and then creates the symlink forresourcesdirectory.dapr run --resources-path-> uses provided path in through flagdapr run --components-path-> uses provided path in through flagdapr run-> precedence order is resources dir then components dir.componentsandresourceswill always be in sync, it wont matter where the new resources are put but the recommendation isresourcesdirectory ascomponentswill be deprecated in future.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1148
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: