Merged
Conversation
Signed-off-by: nelson.parente <nelson_parente@live.com.pt>
Signed-off-by: nelson.parente <nelson_parente@live.com.pt>
Signed-off-by: nelson.parente <nelson_parente@live.com.pt>
Signed-off-by: nelson.parente <nelson_parente@live.com.pt>
fd981cb to
91cb49e
Compare
Signed-off-by: nelson.parente <nelson_parente@live.com.pt>
Closed
Signed-off-by: nelson.parente <nelson_parente@live.com.pt>
Signed-off-by: nelson.parente <nelson_parente@live.com.pt>
Signed-off-by: nelson.parente <nelson_parente@live.com.pt>
yaron2
approved these changes
Aug 12, 2025
javier-aliaga
pushed a commit
to javier-aliaga/cli
that referenced
this pull request
Sep 9, 2025
* feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: bump golangcilint version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: tests Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: resolve non-constant format string errors Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: linter errs Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: ensure certs do not exist Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: remove TODO in test Signed-off-by: nelson.parente <nelson_parente@live.com.pt> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
pushed a commit
to javier-aliaga/cli
that referenced
this pull request
Sep 9, 2025
* feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: bump golangcilint version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: tests Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: resolve non-constant format string errors Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: linter errs Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: ensure certs do not exist Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: remove TODO in test Signed-off-by: nelson.parente <nelson_parente@live.com.pt> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
pushed a commit
to javier-aliaga/cli
that referenced
this pull request
Sep 10, 2025
* feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: bump golangcilint version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: tests Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: resolve non-constant format string errors Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: linter errs Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: ensure certs do not exist Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: remove TODO in test Signed-off-by: nelson.parente <nelson_parente@live.com.pt> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
pushed a commit
to javier-aliaga/cli
that referenced
this pull request
Sep 10, 2025
* feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: bump golangcilint version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: tests Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: resolve non-constant format string errors Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: linter errs Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: ensure certs do not exist Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: remove TODO in test Signed-off-by: nelson.parente <nelson_parente@live.com.pt> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io>
JoshVanL
added a commit
that referenced
this pull request
Sep 12, 2025
* feat: update d/d to 1.16.0-rc3 (#1527) * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: bump golangcilint version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: tests Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: resolve non-constant format string errors Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: linter errs Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: ensure certs do not exist Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: remove TODO in test Signed-off-by: nelson.parente <nelson_parente@live.com.pt> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Update the versions in the upgrade test It will now test 1.14.5, 1.15.11 and 1.16.0-rc.7. Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Fix generate certificates using new version Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Fix tests Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Update go version Signed-off-by: Javier Aliaga <javier@diagrid.io> * ci: Update pinned versions Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Increase e2e template test sleep Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Use go 1.24 Signed-off-by: Javier Aliaga <javier@diagrid.io> * fix: Print stop jobs result Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Remove close app as they are cancelled when the context is cancelled Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Increase wait period Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Run processor app in different ports Signed-off-by: Javier Aliaga <javier@diagrid.io> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Nelson Parente <nelson_parente@live.com.pt> Co-authored-by: Albert Callarisa <albert@diagrid.io> Co-authored-by: joshvanl <me@joshvanl.dev>
JoshVanL
added a commit
to JoshVanL/dapr-cli
that referenced
this pull request
Sep 30, 2025
* feat: update d/d to 1.16.0-rc3 (dapr#1527) * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: bump golangcilint version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: tests Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: resolve non-constant format string errors Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: linter errs Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: ensure certs do not exist Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: remove TODO in test Signed-off-by: nelson.parente <nelson_parente@live.com.pt> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Update the versions in the upgrade test It will now test 1.14.5, 1.15.11 and 1.16.0-rc.7. Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Fix generate certificates using new version Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Fix tests Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Update go version Signed-off-by: Javier Aliaga <javier@diagrid.io> * ci: Update pinned versions Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Increase e2e template test sleep Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Use go 1.24 Signed-off-by: Javier Aliaga <javier@diagrid.io> * fix: Print stop jobs result Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Remove close app as they are cancelled when the context is cancelled Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Increase wait period Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Run processor app in different ports Signed-off-by: Javier Aliaga <javier@diagrid.io> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Nelson Parente <nelson_parente@live.com.pt> Co-authored-by: Albert Callarisa <albert@diagrid.io> Co-authored-by: joshvanl <me@joshvanl.dev>
JoshVanL
added a commit
to JoshVanL/dapr-cli
that referenced
this pull request
Oct 31, 2025
* feat: update d/d to 1.16.0-rc3 (dapr#1527) * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: bump golangcilint version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: tests Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: resolve non-constant format string errors Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: linter errs Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: ensure certs do not exist Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: remove TODO in test Signed-off-by: nelson.parente <nelson_parente@live.com.pt> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Update the versions in the upgrade test It will now test 1.14.5, 1.15.11 and 1.16.0-rc.7. Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Fix generate certificates using new version Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Fix tests Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Update go version Signed-off-by: Javier Aliaga <javier@diagrid.io> * ci: Update pinned versions Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Increase e2e template test sleep Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Use go 1.24 Signed-off-by: Javier Aliaga <javier@diagrid.io> * fix: Print stop jobs result Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Remove close app as they are cancelled when the context is cancelled Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Increase wait period Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Run processor app in different ports Signed-off-by: Javier Aliaga <javier@diagrid.io> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Nelson Parente <nelson_parente@live.com.pt> Co-authored-by: Albert Callarisa <albert@diagrid.io> Co-authored-by: joshvanl <me@joshvanl.dev>
cicoyle
pushed a commit
to cicoyle/cli
that referenced
this pull request
Nov 10, 2025
* feat: update d/d to 1.16.0-rc3 (dapr#1527) * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: bump golangcilint version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: tests Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: resolve non-constant format string errors Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: linter errs Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * feat: update dapr version Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: ensure certs do not exist Signed-off-by: nelson.parente <nelson_parente@live.com.pt> * fix: remove TODO in test Signed-off-by: nelson.parente <nelson_parente@live.com.pt> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Update the versions in the upgrade test It will now test 1.14.5, 1.15.11 and 1.16.0-rc.7. Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Fix generate certificates using new version Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: Javier Aliaga <javier@diagrid.io> * Fix tests Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Update go version Signed-off-by: Javier Aliaga <javier@diagrid.io> * ci: Update pinned versions Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Increase e2e template test sleep Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Use go 1.24 Signed-off-by: Javier Aliaga <javier@diagrid.io> * fix: Print stop jobs result Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Remove close app as they are cancelled when the context is cancelled Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Increase wait period Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Run processor app in different ports Signed-off-by: Javier Aliaga <javier@diagrid.io> --------- Signed-off-by: nelson.parente <nelson_parente@live.com.pt> Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Nelson Parente <nelson_parente@live.com.pt> Co-authored-by: Albert Callarisa <albert@diagrid.io> Co-authored-by: joshvanl <me@joshvanl.dev> Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Contributor
|
@holopin-bot @nelson-parente Here's a digital badge as a small token of appreciation. |
|
Congratulations @nelson-parente, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmi4ez5ox000ajw04yn3o6k4a This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates dependencies, improves formatting and logging consistency, and makes minor workflow and linter configuration changes. The most significant updates are dependency bumps in
go.mod, which bring in newer versions of core and indirect libraries, as well as a switch to more consistent formatting for status and logging functions throughout the codebase.Dependency Updates:
go.mod, including major upgrades togithub.com/dapr/dapr,github.com/dapr/kit,k8s.io/apimachinery,github.com/spf13/cobra,golang.org/x/*modules, and many others. This ensures compatibility with the latest features and security patches. [1] [2] [3] [4] [5] [6] [7] [8] [9]Formatting and Logging Consistency:
Refactored calls to status and spinner functions to use format strings (e.g.,
"%s") instead of string concatenation, improving consistency and reducing potential formatting errors inpkg/print/print.go,pkg/kubernetes/kubernetes.go,pkg/kubernetes/mtls.go,pkg/kubernetes/upgrade.go, andpkg/standalone/standalone.go. [1] [2] [3] [4] [5] [6] [7] [8]Improved log output handling in
CustomLogWriterby adding error checking to the regex compilation, which makes the code more robust.CI/CD and Linting Configuration:
v1.64.2in the GitHub Actions workflow and adjusted.golangci.ymlsettings to usedefault: allinstead ofenable-all: true, and removed/disabled some specific linters for better control. [1] [2] [3] [4]Miscellaneous Improvements:
t.Context()in server shutdown calls and fixing a logging format in a test. [1] [2] [3]