Simpler and safer spawn of dapr comands in tests #1545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Callarisa <[email protected]>
acroca
force-pushed
the
refactor-cmd-spawn
branch
from
23cf51a to
788139d
Compare
Signed-off-by: Albert Callarisa <[email protected]>
Signed-off-by: Albert Callarisa <[email protected]>
acroca
force-pushed
the
refactor-cmd-spawn
branch
from
ae94b5e to
b476742
Compare
Signed-off-by: Albert Callarisa <[email protected]>
acroca
force-pushed
the
refactor-cmd-spawn
branch
from
7020313 to
a3b5b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified how we spawn and stop dapr commads in the standalone e2e tests.
The main execution path will just hang in the
Wait, so whatever makes the wait complete, will terminate the function call.On top of that, we add 30s timeout to the context (which triggers a Kill on the process) and a 20s SIGTERM for a graceful shutdown.
Also brought back the test ports to use the same port on all instances. We changed the ports because we were having issues with the port being used. Processes should be started and stopped within the test and the ports should be free again for the next test to run.