Skip to content

feat(kinesis): upgrade vmware-go-kcl to vmware-go-kcl-v2 #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

feat(kinesis): upgrade vmware-go-kcl to vmware-go-kcl-v2 #3986

wants to merge 38 commits into from
+90 −66

Conversation

swatimodi-scout
Copy link
Contributor

Description

This PR upgrades the AWS Kinesis input binding to use the newer vmware-go-kcl-v2 library.

  • Motivation: The legacy vmware-go-kcl is unmaintained and lacks important bug fixes and improvements.
  • Change details:
    • Updated go.mod to require github.com/vmware/vmware-go-kcl-v2.
    • Updated relevant import paths across the codebase.
    • Adjusted worker configuration and API usage to match v2 interface changes.
    • Ensured compatibility with existing Kinesis input binding behavior through tests.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[3985]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.

swatimodi-scout and others added 30 commits August 4, 2025 07:41
@swatimodi-scout
Added enpoint in configuration
20f8633
@swatimodi-scout
Merge pull request #1 from swatimodi-scout/kinesis-dapr
6e0221c 
Added enpoint in configuration
@devendrapohekar-scout
fix: Handle 'extended' KinesisConsumerMode and prevent nil pointer er…
d891be8 
…rors

- Invoke logic only when KinesisConsumerMode is set to 'extended' to avoid unnecessary calls
- Skip next step if error is not nil to prevent nil pointer errors on StreamDescription.StreamARN.
@devendrapohekar-scout
fix: update comments.
281c7bd
@swatimodi-scout
Merge pull request #2 from swatimodi-scout/kinesis-nil-pointer-extend…
0ebbf9f 
…ed-invoke

Kinesis nil pointer extended invoke
@devendrapohekar-scout
feat: upgradevmware-go-kcl to vmware-go-kcl-v2.
e25da28
@devendrapohekar-scout
feat: update endpoint and revert back some changes.
792c790
@javier-aliaga @yaron2
@cicoyle @swatimodi-scout
chore: Use base64 to store sqlserver state data (dapr#3919)
df6c7f1 
Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@pnagaraj80 @cicoyle
@yaron2 @dapr-bot @swatimodi-scout
feat: Add support for replicateSubscriptionState in Pulsar pubsub com…
af96042 
…ponent (dapr#3853)

Signed-off-by: Prashanth Nagaraj <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@cicoyle @swatimodi-scout
Update PR template (dapr#3866)
cc86b54 
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@swatimodi-scout
Added enpoint in configuration
7aa17f1 
Signed-off-by: swatimodi-scout <[email protected]>
@devendrapohekar-scout @swatimodi-scout
fix: Handle 'extended' KinesisConsumerMode and prevent nil pointer er…
15d4d88 
…rors

- Invoke logic only when KinesisConsumerMode is set to 'extended' to avoid unnecessary calls
- Skip next step if error is not nil to prevent nil pointer errors on StreamDescription.StreamARN.

Signed-off-by: swatimodi-scout <[email protected]>
@devendrapohekar-scout @swatimodi-scout
fix: update comments.
2d77bbf 
Signed-off-by: swatimodi-scout <[email protected]>
@filintod @yaron2 @swatimodi-scout
Conversation Tool Calling fix on echo and other minor fixes (dapr#3930)
f7251b7 
Signed-off-by: Filinto Duran <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@aladd04 @yaron2 @swatimodi-scout
fix: 'ttlInSeconds' metadata key now respected when publishing to Azu…
6b1dc03 
…re Service Bus Topics. (dapr#3942)

Signed-off-by: Andy Ladd <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@javier-aliaga @yaron2 @swatimodi-scout
chore: Move kafka to use aws sdk v2 (dapr#3940)
7cccdc6 
Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@mikeee @yaron2 @swatimodi-scout
fix(common): add missing region and remove session token requirement (d…
0fbe3a7 
…apr#3914)

Signed-off-by: Mike Nguyen <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@sicoyle @swatimodi-scout
feat: add pubsub proper registrations (dapr#3957)
fff8e4c 
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@sicoyle @swatimodi-scout
feat: crypto comp registration fixes (dapr#3954)
4dd3809 
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@sicoyle @swatimodi-scout
feat: proper secretstore registration fixes (dapr#3952)
413c04c 
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@sicoyle @swatimodi-scout
feat: lock comp registration fixes (dapr#3953)
b3c3b34 
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@sicoyle @swatimodi-scout
feat: add middleware comp proper registrations (dapr#3956)
9d2a54e 
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@nelson-parente @swatimodi-scout
Revert "chore: Use base64 to store sqlserver state data" (dapr#3966)
750a42a 
Signed-off-by: swatimodi-scout <[email protected]>
@swatimodi-scout @peterdalinis-scout @yaron2
Added enpoint in configuration (dapr#3931)
b714d65 
Signed-off-by: swatimodi-scout <[email protected]>
Co-authored-by: peterdalinis-scout <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@nelson-parente @swatimodi-scout
fix: pin macos-14 (dapr#3972)
3bf76a6 
Signed-off-by: nelson.parente <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@olitomlinson @yaron2 @swatimodi-scout
fixed the kubernetes secret component for cryptography (dapr#3971)
04a677e 
Signed-off-by: Oliver Tomlinson <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@mikeee @swatimodi-scout
fix: pubsub.azure.eventhubs status check (dapr#3976)
dff826a 
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@mikeee @yaron2 @swatimodi-scout
fix(tests): fix state.azure.tablestorage cert test (dapr#3975)
b327211 
Signed-off-by: Mike Nguyen <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@sicoyle @yaron2 @swatimodi-scout
fix(test): up ngrok version + fix silent failure on url parsing (dapr…
e240fba 
…#3969)

Signed-off-by: Samantha Coyle <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@Eileen-Yu @yaron2 @swatimodi-scout
fix: postgresql doc link fix (dapr#3904)
eaf31b0 
Signed-off-by: Eileen Yu <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
sicoyle and others added 3 commits August 19, 2025 12:39
@sicoyle @yaron2 @swatimodi-scout
feat: add state component registrations (dapr#3951)
5f9743e 
Signed-off-by: Samantha Coyle <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: swatimodi-scout <[email protected]>
@swatimodi-scout
Merge branch 'main' into main
13763ee
@swatimodi-scout
Formatted gofumpt File
07178fb 
Signed-off-by: swatimodi-scout <[email protected]>
@swatimodi-scout swatimodi-scout requested review from a team as code owners August 20, 2025 10:19
@swatimodi-scout
Copy link
Contributor Author

@yaron2 Please close this PR. I'll raise fresh new PR for this change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.