Skip to content

Azure Event Hub: Add header key sanitization to ensure valid HTTP header names #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −3
Open

Azure Event Hub: Add header key sanitization to ensure valid HTTP header names #4001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions common/component/azure/eventhubs/events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package eventhubs

import (
"context"
"regexp"
"strconv"
"time"

Expand Down Expand Up @@ -124,19 +125,28 @@ func NewBulkMessageEntryFromEventData(e *azeventhubs.ReceivedEventData, topic st
return entry, nil
}

// Allowed: letters, digits, and hyphens.
var headerKeySanitizer = regexp.MustCompile(`[^a-zA-Z0-9-]`)

// Replaces any character not allowed in HTTP header names with '-'.
func sanitizeHeaderKey(key string) string {
return headerKeySanitizer.ReplaceAllString(key, "-")
}

// Adds a property to the response metadata
func addPropertyToMetadata(key string, value any, md map[string]string) {
safeKey := sanitizeHeaderKey(key)
switch v := value.(type) {
case *time.Time:
if v != nil {
md[key] = v.Format(time.RFC3339)
md[safeKey] = v.Format(time.RFC3339)
}
case time.Time:
md[key] = v.Format(time.RFC3339)
md[safeKey] = v.Format(time.RFC3339)
default:
str, err := cast.ToStringE(value)
if err == nil {
md[key] = str
md[safeKey] = str
}
}
}