Adds Global TTL Configuration for DynamoDB State Store #4055
+220
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice when the different statestores (Redis and Dynamo) behave in a similar way. |
|
There will be a slight delay in reviewing the DynamoDB-related PRs. We need to address the missing/disabled tests first, which are being tracked in issue #4047. Thanks for your patience! |
sicoyle
reviewed
Oct 21, 2025
|
@sicoyle Ready for another review round |
sicoyle
reviewed
Oct 27, 2025
Fixed. Also updated the docs PR with the same description |
Signed-off-by: Zeynel Koca <[email protected]>
Signed-off-by: Zeynel Koca <[email protected]>
Signed-off-by: Zeynel Koca <[email protected]>
Co-authored-by: Sam <[email protected]> Signed-off-by: Zeynel <[email protected]>
Signed-off-by: Zeynel Koca <[email protected]>
Co-authored-by: Sam <[email protected]> Signed-off-by: Zeynel <[email protected]>
ZeynelKoca
force-pushed
the
dynamo-global-ttl
branch
from
b51bf00 to
e01dcdf
Compare
sicoyle
previously approved these changes
Oct 30, 2025
|
@ZeynelKoca pls see the build failures and ping when you're ready and I can retrigger 🙏 |
ZeynelKoca
force-pushed
the
dynamo-global-ttl
branch
from
50d65a1 to
e01dcdf
Compare
Signed-off-by: Zeynel Koca <[email protected]>
|
@sicoyle Fixed a stupid rebase mistake. Try again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a way to globally configure the state TTL for dynamo (inspired by #1059).
The defined default TTL will only be used if the state request does not explicitly specify a TTL itself.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: