Skip to content

feat: enable endpoint field on mistral conversation component #4077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

feat: enable endpoint field on mistral conversation component #4077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions conversation/mistral/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,9 @@ metadata:
A time-to-live value for a prompt cache to expire. Uses Golang durations
type: string
example: '10m'
- name: endpoint
required: false
description: |
Endpoint for the component to use.
example: "http://localhost:4566"
default: "https://api.mistral.ai/v1"
5 changes: 5 additions & 0 deletions conversation/mistral/mistral.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,14 @@ func (m *Mistral) Init(ctx context.Context, meta conversation.Metadata) error {
// Resolve model via central helper (uses metadata, then env var, then default)
model := conversation.GetMistralModel(md.Model)

if md.Endpoint == "" {
md.Endpoint = "https://api.mistral.ai/v1"
}

llm, err := mistral.New(
mistral.WithModel(model),
mistral.WithAPIKey(md.Key),
mistral.WithEndpoint(md.Endpoint),
)
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion tests/conformance/conversation/conversation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ func ConformanceTests(t *testing.T, props map[string]string, conv conversation.C
responseMessages = append(responseMessages,
llms.MessageContent{
Role: llms.ChatMessageTypeAI,
Parts: []llms.ContentPart{toolCall},
Parts: []llms.ContentPart{&toolCall},
},
llms.MessageContent{
Role: llms.ChatMessageTypeTool,
Expand Down