Refactor quickstarts: reorganized hello-world#296
Merged
Conversation
…ello-world quickstarts - Removed durable agent examples from 01-hello-world (03_durable_agent_*.py, message_client.py) - Added durable weather agent variants to 03-durable-agent-tool-call (durable_weather_agent_serve.py, durable_weather_agent_subscribe.py, message_client.py) - Added four new foundational quickstarts to 01-hello-world (01_agent_with_memory.py, 02_agent_with_durable_execution.py, 03_workflow_with_llms.py, 04_workflow_with_agents.py) - Updated tests: removed old tests from test_01_hello_world.py, added tests for new quickstarts, and added tests for weather agent serve/subscribe modes in test_03_durable_agent_tool_call.py - Updated READMEs in both quickstarts to reflect new structure and examples Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Member
|
@bibryam This is still in Draft - is it ready for review? |
Collaborator
Author
|
Sorry, I just converted it to draft. I wanna include a few more changes. |
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Collaborator
The smaller and more focused the PR is on the changeset, the better 🙏 @bibryam |
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Collaborator
|
/ok-to-test |
sicoyle
previously approved these changes
Dec 15, 2025
Collaborator
sicoyle
left a comment
sicoyle
left a comment
There was a problem hiding this comment.
overall LGTM, thank you 🙌 I actually didn't even know about the dapr publish cli cmd, so that is a great change apart of this effort!
Signed-off-by: Bilgin Ibryam <bibryam@gmail.com>
Collaborator
|
Did you run the integration tests for this @bibryam ? |
sicoyle
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor quickstarts: reorganize durable agent examples and add new hello-world quickstarts
Description
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
#284
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.