Skip to content

fix: handle summarize bug + concurrent registrations#483

Merged
sicoyle merged 2 commits intodapr:mainfrom
sicoyle:fix-summarize-bug
Mar 6, 2026
Merged

fix: handle summarize bug + concurrent registrations#483
sicoyle merged 2 commits intodapr:mainfrom
sicoyle:fix-summarize-bug

Conversation

@sicoyle
Copy link
Collaborator

@sicoyle sicoyle commented Mar 6, 2026

Description

This PR fixes the concurrent write issue for agent registration by removing the ensure_registry_initialized func as our registration function itself already handles cases where the key doesn't exist as well as when the key exists and we need an update.

It also fixes this one from Alice

Activity task #7 failed: LLM summarize failed: Extraction failed: No tool_calls found for function_call mode

If the LLM returns plain JSON, then we should support JSON here too.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR closes: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Created/updated tests
  • Tested this change against all the quickstarts
  • Extended the documentation

Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.

Signed-off-by: Samantha Coyle <sam@diagrid.io>
Copilot AI review requested due to automatic review settings March 6, 2026 20:50
@sicoyle sicoyle requested review from a team as code owners March 6, 2026 20:50
@sicoyle sicoyle review requested due to automatic review settings March 6, 2026 20:52
@sicoyle
Copy link
Collaborator Author

sicoyle commented Mar 6, 2026

/ok-to-test

@sicoyle
Copy link
Collaborator Author

sicoyle commented Mar 6, 2026

ignore me ^ just seeing where it's at again 🙃

@sicoyle sicoyle merged commit 17b3814 into dapr:main Mar 6, 2026
8 checks passed
@sicoyle sicoyle deleted the fix-summarize-bug branch March 6, 2026 20:53
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Integration Tests Summary

Python Version Status
3.10 ❌ FAILED
3.11 ❌ FAILED
3.12 ❌ FAILED
3.13 ❌ FAILED

Overall Status: ❌ Some tests failed
Workflow: View run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants