-
Notifications
You must be signed in to change notification settings - Fork 771
Update actor state store docs to include strong consistency requirement #4766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1.16
Are you sure you want to change the base?
Update actor state store docs to include strong consistency requirement #4766
Conversation
Signed-off-by: Jonathan Collinge <[email protected]>
6a4a886
to
14cfcf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yaron2 shall I close this or ok to merge? |
Technically we don't require the state store to be strongly consistent, meaning Dapr will not error or issue a warning if a non consistent store is chose. That's because the runtime code doesn't make explicit use of the consistency settings when using the State API interface from contrib. That said it should be recommended that users choosing a multi-replica database set it to strong consistency from the database side, so I'm happy if the PR is changed to reflect that |
Signed-off-by: Jonathan Collinge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jonathan Collinge [email protected]
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Updates the state store documentation for actor state stores to make it clear that it must be setup with strong consistency as outlined in the state store design reference https://github.com/dapr/dapr/blob/master/docs/decision_records/api/API-005-state-store-behavior.md. Its possible that people are using state stores that are "actor compatible" but with a weaker consistency model which can cause undefined behaviour.
Issue reference