-
Notifications
You must be signed in to change notification settings - Fork 778
Chore: jaeger guidance #4923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MyMirelHub
wants to merge
2
commits into
dapr:v1.16
Choose a base branch
from
MyMirelHub:chore-jaeger-guidance
base: v1.16
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−1
Open
Chore: jaeger guidance #4923
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other edit you can do here is say that in the development environment navigate to the local dapr folder (add this reference link https://docs.dapr.io/getting-started/install-dapr-selfhost/#step-5-verify-components-directory-has-been-initialized) and update the default
config.yamlfile with these changes.Can I also suggest that in this article https://docs.dapr.io/getting-started/install-dapr-selfhost/ we add an "Optional Step 6. Configure JaegerV2 for local tracing instead of Zipkin" and then add a link to this article. That is to give people a choice of the local tracing experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other things to update
"1. Create a configuration file (e.g.,
tracing.yaml)" - Should be ->"1. Create a configuration file (for exampletracing.yaml)Why install cert- manager? And if so, why is this setting
isSecure: false. I would expect that we show how to install secure connect with a cert (hence cert-manager yes)?Is these namespace below correct between the deployment and when you say "opentelemetry-operator-system" namespace?
Confirm that all resources in the
opentelemetry-operator-systemnamespace are ready.Deploy a Jaeger V2 instance with in-memory storage:
Apply the following configuration to create a Jaeger V2 instance: