feat: add application-level keepalive to prevent ALB idle connection timeouts#1739
Open
JoshVanL wants to merge 2 commits intodapr:masterfrom
Open
feat: add application-level keepalive to prevent ALB idle connection timeouts#1739JoshVanL wants to merge 2 commits intodapr:masterfrom
JoshVanL wants to merge 2 commits intodapr:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an application-level keepalive mechanism to the workflow worker’s gRPC connection so idle connections aren’t dropped by L7 load balancers (e.g., AWS ALB) that don’t forward HTTP/2 PING frames.
Changes:
- Start a background keepalive loop alongside the existing server-stream receive loop.
- Implement
KeepaliveLoopAsyncto periodically call the existingHelloRPC. - Add a debug log event for keepalive failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/Dapr.Workflow/Worker/Grpc/GrpcProtocolHandler.cs |
Starts/stops a background keepalive task and implements periodic Hello calls. |
src/Dapr.Workflow/Logging.cs |
Adds a new generated log message for keepalive failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
…timeouts AWS ALBs do not forward HTTP/2 PING frames, causing idle gRPC connections to be closed. This adds a background loop that periodically calls the existing Hello RPC as application-level traffic to keep the connection alive through L7 load balancers. Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
grpc-keepalive-hello
branch
from
1176dd9 to
2b12a4c
Compare
Contributor
|
Do note that I just merged a PR to support xUnit v3 so your unit/integration tests may need a refresh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS ALBs do not forward HTTP/2 PING frames, causing idle gRPC connections to be closed. This adds a background loop that periodically calls the existing Hello RPC as application-level traffic to keep the connection alive through L7 load balancers.