forked from microsoft/durabletask-java
-
Notifications
You must be signed in to change notification settings - Fork 8
Task execution #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Task execution #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b2286c
to
5a829f5
Compare
d6687dd
to
ca11869
Compare
ca11869
to
11afac5
Compare
Signed-off-by: Javier Aliaga <[email protected]>
* Fix integration test retry extension The integration tests were using a retry extension that was eating exceptions and hiding failures. This commit removes the customer extension and relies on gradle's built in retry. Signed-off-by: Hal Spang <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
11afac5
to
baa8dd7
Compare
Signed-off-by: Javier Aliaga <[email protected]>
c779a62
to
5e0a8f6
Compare
Signed-off-by: Javier Aliaga <[email protected]>
/LGTM let's merge this |
Signed-off-by: Javier Aliaga <[email protected]>
cicoyle
reviewed
Jul 7, 2025
cicoyle
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this for now, but if we can come back in and add something like we have in Go where we assert eventually, then we can potentially get the best of both worlds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Propagates taskExecutionId from runtime to activityContext
The taskExecutionId is the same among retries but different among executions
Cherrypick from microsoft:
197d761
Depends on:
dapr/durabletask-protobuf#13
dapr/durabletask-go#25
implements:
dapr/proposals#85
Pull request checklist
CHANGELOG.md
Additional information
Additional PR information