Skip to content

Conversation

javier-aliaga
Copy link

Issue describing the changes in this PR

Propagates taskExecutionId from runtime to activityContext

The taskExecutionId is the same among retries but different among executions

Cherrypick from microsoft:
197d761

Depends on:
dapr/durabletask-protobuf#13
dapr/durabletask-go#25

implements:
dapr/proposals#85

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

javier-aliaga and others added 3 commits July 4, 2025 13:43
* Fix integration test retry extension

The integration tests were using a retry extension that was
eating exceptions and hiding failures. This commit removes
the customer extension and relies on gradle's built in retry.

Signed-off-by: Hal Spang <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
@javier-aliaga javier-aliaga marked this pull request as ready for review July 7, 2025 07:19
@salaboy
Copy link
Collaborator

salaboy commented Jul 7, 2025

/LGTM let's merge this

Copy link
Collaborator

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this for now, but if we can come back in and add something like we have in Go where we assert eventually, then we can potentially get the best of both worlds.

@cicoyle cicoyle merged commit a898cd7 into dapr:main Jul 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants