Skip to content

try-catch #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cicoyle merged 3 commits into from
May 7, 2025
Merged

try-catch #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2e5245
try-catch
cicoyle May 7, 2025
18e5901
log unexpected shutdown
cicoyle May 7, 2025
f7ddbba
move shutdown to close()
cicoyle May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public final class DurableTaskGrpcWorker implements AutoCloseable {
private final ExecutorService workerPool;

private final TaskHubSidecarServiceBlockingStub sidecarClient;
private volatile boolean isNormalShutdown = false;

DurableTaskGrpcWorker(DurableTaskGrpcWorkerBuilder builder) {
this.orchestrationFactories.putAll(builder.orchestrationFactories);
Expand Down Expand Up @@ -86,6 +87,7 @@ public void start() {
* configured.
*/
public void close() {
this.isNormalShutdown = true;
this.shutDownWorkerPool();
this.closeSideCarChannel();
}
Expand Down Expand Up @@ -136,7 +138,17 @@ public void startAndBlock() {
.setCustomStatus(StringValue.of(taskOrchestratorResult.getCustomStatus()))
.build();

this.sidecarClient.completeOrchestratorTask(response);
try {
this.sidecarClient.completeOrchestratorTask(response);
} catch (StatusRuntimeException e) {
if (e.getStatus().getCode() == Status.Code.UNAVAILABLE) {
logger.log(Level.WARNING, "The sidecar at address {0} is unavailable while completing the orchestrator task.", this.getSidecarAddress());
} else if (e.getStatus().getCode() == Status.Code.CANCELLED) {
logger.log(Level.WARNING, "Durable Task worker has disconnected from {0} while completing the orchestrator task.", this.getSidecarAddress());
} else {
logger.log(Level.WARNING, "Unexpected failure completing the orchestrator task at {0}.", this.getSidecarAddress());
}
}
});
} else if (requestType == RequestCase.ACTIVITYREQUEST) {
ActivityRequest activityRequest = workItem.getActivityRequest();
Expand Down Expand Up @@ -169,7 +181,17 @@ public void startAndBlock() {
responseBuilder.setFailureDetails(failureDetails);
}

this.sidecarClient.completeActivityTask(responseBuilder.build());
try {
this.sidecarClient.completeActivityTask(responseBuilder.build());
} catch (StatusRuntimeException e) {
if (e.getStatus().getCode() == Status.Code.UNAVAILABLE) {
logger.log(Level.WARNING, "The sidecar at address {0} is unavailable while completing the activity task.", this.getSidecarAddress());
} else if (e.getStatus().getCode() == Status.Code.CANCELLED) {
logger.log(Level.WARNING, "Durable Task worker has disconnected from {0} while completing the activity task.", this.getSidecarAddress());
} else {
logger.log(Level.WARNING, "Unexpected failure completing the activity task at {0}.", this.getSidecarAddress());
}
}
});
} else {
logger.log(Level.WARNING, "Received and dropped an unknown '{0}' work-item from the sidecar.", requestType);
Expand Down Expand Up @@ -214,7 +236,9 @@ private void closeSideCarChannel() {
}

private void shutDownWorkerPool() {
logger.log(Level.WARNING, "ExecutorService shutdown initiated. No new tasks will be accepted");
if (!this.isNormalShutdown) {
logger.log(Level.WARNING, "ExecutorService shutdown initiated unexpectedly. No new tasks will be accepted");
}

this.workerPool.shutdown();
try {
Expand Down
Loading