feat: add application-level keepalive to prevent ALB idle connection timeouts#7
Open
feat: add application-level keepalive to prevent ALB idle connection timeouts#7
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an application-level keepalive mechanism to the gRPC worker to prevent idle connections (e.g., behind AWS ALBs) from being closed by periodically invoking the existing Hello RPC.
Changes:
- Extends
TaskHubGrpcWorkerconstructor to accept an optionalkeepaliveIntervalMs(defaulting to 30s). - Starts a periodic
hello(Empty)call once the work-item stream is established. - Ensures the keepalive timer is cleared on stop and on stream end/exception paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
…timeouts AWS ALBs do not forward HTTP/2 PING frames, causing idle gRPC connections to be closed. This adds a background loop that periodically calls the existing Hello RPC as application-level traffic to keep the connection alive through L7 load balancers. Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
grpc-keepalive-hello
branch
from
6d5fa45 to
481babc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS ALBs do not forward HTTP/2 PING frames, causing idle gRPC connections to be closed. This adds a background loop that periodically calls the existing Hello RPC as application-level traffic to keep the connection alive through L7 load balancers.