Skip to content

feat: Add taskExecutionId field #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

feat: Add taskExecutionId field #13

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6d5eaa
chore: Add taskExecutionId field
javier-aliaga Jun 16, 2025
be490c5
fix: indentation
javier-aliaga Jun 16, 2025
ecfd5c8
fix: Indentation
javier-aliaga Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions protos/orchestrator_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ message ActivityRequest {
OrchestrationInstance orchestrationInstance = 4;
int32 taskId = 5;
TraceContext parentTraceContext = 6;
string taskExecutionId = 7;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What value is to be expected here and by who?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this value is used to propagate the taskExecutionId from the scheduled task to the worker to build the context

https://github.com/dapr/durabletask-go/blob/28ab9ebfa7bb2f1d6d0237b5d2ce60b6be712e2b/backend/executor.go#L161 and https://github.com/dapr/durabletask-go/blob/28ab9ebfa7bb2f1d6d0237b5d2ce60b6be712e2b/client/worker_grpc.go#L187

}

message ActivityResponse {
Expand Down Expand Up @@ -99,16 +100,19 @@ message TaskScheduledEvent {
google.protobuf.StringValue version = 2;
google.protobuf.StringValue input = 3;
TraceContext parentTraceContext = 4;
string taskExecutionId = 5;
}

message TaskCompletedEvent {
int32 taskScheduledId = 1;
google.protobuf.StringValue result = 2;
string taskExecutionId = 3;
}

message TaskFailedEvent {
int32 taskScheduledId = 1;
TaskFailureDetails failureDetails = 2;
string taskExecutionId = 3;
}

message SubOrchestrationInstanceCreatedEvent {
Expand Down Expand Up @@ -263,6 +267,7 @@ message ScheduleTaskAction {
google.protobuf.StringValue version = 2;
google.protobuf.StringValue input = 3;
optional TaskRouter router = 4;
string taskExecutionId = 5;
}

message CreateSubOrchestrationAction {
Expand Down