-
Notifications
You must be signed in to change notification settings - Fork 186
chore: Support taskExecutionId #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a52b42a
chore: Support taskExecutionId
javier-aliaga 2ef13fb
chore: Create new example
javier-aliaga 6ff2210
chore(temp): bump cli/dapr validation workflow versions
mikeee 5cac58c
chore: tidy deps
mikeee 33aa584
chore: bump protos to rc3-ish
mikeee 8edd834
fix: go.mod
javier-aliaga 2b6eb66
chore: Use rc3
javier-aliaga fa9290f
Merge branch 'main' into execution-task-id
yaron2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Dapr Parallel Workflow Example with go-sdk | ||
|
|
||
| ## Step | ||
|
|
||
| ### Prepare | ||
|
|
||
| - Dapr installed | ||
|
|
||
| ### Run Workflow | ||
|
|
||
| <!-- STEP | ||
| name: Run Workflow | ||
| output_match_mode: substring | ||
| expected_stdout_lines: | ||
| - '== APP == Workflow(s) and activities registered.' | ||
| - 'work item listener started' | ||
| - '== APP == RetryN 1' | ||
| - '== APP == RetryN 2' | ||
| - '== APP == RetryN 3' | ||
| - '== APP == RetryN 4' | ||
| - '== APP == RetryN 1' | ||
| - '== APP == RetryN 2' | ||
| - '== APP == RetryN 3' | ||
| - '== APP == RetryN 4' | ||
| - '== APP == workflow status: COMPLETED' | ||
| - '== APP == workflow terminated' | ||
| - '== APP == workflow purged' | ||
|
|
||
| background: true | ||
| sleep: 30 | ||
| timeout_seconds: 60 | ||
| --> | ||
|
|
||
| ```bash | ||
| dapr run --app-id workflow-taskexecutionid \ | ||
| --dapr-grpc-port 50001 \ | ||
| --log-level debug \ | ||
| --resources-path ./config \ | ||
| -- go run ./main.go | ||
| ``` | ||
|
|
||
| <!-- END_STEP --> | ||
|
|
||
| ## Result | ||
|
|
||
| ``` | ||
| - '== APP == Workflow(s) and activities registered.' | ||
| - 'work item listener started' | ||
| - '== APP == RetryN 1' | ||
| - '== APP == RetryN 2' | ||
| - '== APP == RetryN 3' | ||
| - '== APP == RetryN 4' | ||
| - '== APP == RetryN 1' | ||
| - '== APP == RetryN 2' | ||
| - '== APP == RetryN 3' | ||
| - '== APP == RetryN 4' | ||
| - '== APP == workflow status: COMPLETED' | ||
| - '== APP == workflow terminated' | ||
| - '== APP == workflow purged' | ||
| ``` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| apiVersion: dapr.io/v1alpha1 | ||
| kind: Component | ||
| metadata: | ||
| name: wf-store | ||
| spec: | ||
| type: state.redis | ||
| version: v1 | ||
| metadata: | ||
| - name: redisHost | ||
| value: localhost:6379 | ||
| - name: redisPassword | ||
| value: "" | ||
| - name: actorStateStore | ||
| value: "true" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "log" | ||
| "sync" | ||
| "sync/atomic" | ||
| "time" | ||
|
|
||
| "github.com/dapr/go-sdk/workflow" | ||
| ) | ||
|
|
||
| func main() { | ||
| w, err := workflow.NewWorker() | ||
| if err != nil { | ||
| log.Fatalf("failed to initialise worker: %v", err) | ||
| } | ||
|
|
||
| if err := w.RegisterWorkflow(TaskExecutionIdWorkflow); err != nil { | ||
| log.Fatalf("failed to register workflow: %v", err) | ||
| } | ||
| if err := w.RegisterActivity(RetryN); err != nil { | ||
| log.Fatalf("failed to register activity: %v", err) | ||
| } | ||
| fmt.Println("Workflow(s) and activities registered.") | ||
|
|
||
| if err := w.Start(); err != nil { | ||
| log.Fatalf("failed to start worker") | ||
| } | ||
|
|
||
| wfClient, err := workflow.NewClient() | ||
| if err != nil { | ||
| log.Fatalf("failed to initialise client: %v", err) | ||
| } | ||
| ctx := context.Background() | ||
| id, err := wfClient.ScheduleNewWorkflow(ctx, "TaskExecutionIdWorkflow", workflow.WithInput(5)) | ||
| if err != nil { | ||
| log.Fatalf("failed to schedule a new workflow: %v", err) | ||
| } | ||
|
|
||
| metadata, err := wfClient.WaitForWorkflowCompletion(ctx, id) | ||
| if err != nil { | ||
| log.Fatalf("failed to get workflow: %v", err) | ||
| } | ||
| fmt.Printf("workflow status: %s\n", metadata.RuntimeStatus.String()) | ||
|
|
||
| err = wfClient.TerminateWorkflow(ctx, id) | ||
| if err != nil { | ||
| log.Fatalf("failed to terminate workflow: %v", err) | ||
| } | ||
| fmt.Println("workflow terminated") | ||
|
|
||
| err = wfClient.PurgeWorkflow(ctx, id) | ||
| if err != nil { | ||
| log.Fatalf("failed to purge workflow: %v", err) | ||
| } | ||
| fmt.Println("workflow purged") | ||
| } | ||
|
|
||
| var eMap = sync.Map{} | ||
|
|
||
| func TaskExecutionIdWorkflow(ctx *workflow.WorkflowContext) (any, error) { | ||
| var retries int | ||
| if err := ctx.GetInput(&retries); err != nil { | ||
| return 0, err | ||
| } | ||
|
|
||
| var workBatch []int | ||
| if err := ctx.CallActivity(RetryN, workflow.ActivityRetryPolicy(workflow.RetryPolicy{ | ||
| MaxAttempts: retries, | ||
| InitialRetryInterval: 100 * time.Millisecond, | ||
| BackoffCoefficient: 2, | ||
| MaxRetryInterval: 1 * time.Second, | ||
| }), workflow.ActivityInput(retries)).Await(&workBatch); err != nil { | ||
| return 0, err | ||
| } | ||
|
|
||
| if err := ctx.CallActivity(RetryN, workflow.ActivityRetryPolicy(workflow.RetryPolicy{ | ||
| MaxAttempts: retries, | ||
| InitialRetryInterval: 100 * time.Millisecond, | ||
| BackoffCoefficient: 2, | ||
| MaxRetryInterval: 1 * time.Second, | ||
| }), workflow.ActivityInput(retries)).Await(&workBatch); err != nil { | ||
| return 0, err | ||
| } | ||
|
|
||
| return 0, nil | ||
| } | ||
|
|
||
| func RetryN(ctx workflow.ActivityContext) (any, error) { | ||
| taskExecutionID := ctx.GetTaskExecutionID() | ||
| counter, _ := eMap.LoadOrStore(taskExecutionID, &atomic.Int32{}) | ||
| var retries int32 | ||
| if err := ctx.GetInput(&retries); err != nil { | ||
| return 0, err | ||
| } | ||
|
|
||
| counter.(*atomic.Int32).Add(1) | ||
| fmt.Println("RetryN ", counter.(*atomic.Int32).Load()) | ||
|
|
||
| if counter.(*atomic.Int32).Load() < retries-1 { | ||
| return nil, fmt.Errorf("failed") | ||
| } | ||
|
|
||
| return nil, nil | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please open a quick issue if you don't have time to add the new Alpha2 implementation of the conversation api jsut so we're not ignoring the planned deprecation entirelyCould you please open a quick issue if you don't have time to add the new Alpha2 implementation of the conversation api jsut so we're not ignoring the planned deprecation entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#756