Skip to content

Conversation

@salaboy
Copy link
Collaborator

@salaboy salaboy commented Sep 10, 2024

Description

Initial Spring Boot documentation added to the Java SDK Docs

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1122

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners September 10, 2024 13:04
@salaboy
Copy link
Collaborator Author

salaboy commented Sep 11, 2024

@artursouza @cicoyle please review :)

}
```

You can check and run the [full example source code here](https://github.com/salaboy/dapr-spring-boot-docs-examples).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically link to examples in the java-sdk so that they are maintained and kept updated. Is this example in the sdk and if not, can you add it?

Copy link
Collaborator Author

@salaboy salaboy Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cicoyle This is a bit different, as it uses Testcontainers and the intention here is to keep it as simple as possible for spring users to copy. Maybe we can have a separate directory for it inside the examples, but I wanted to make sure that this doesn't get all the dependencies from other examples that overly complicate it when users want to copy the project structure.

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text looks good to me, so Ill approve - still think we want this in the java-sdk or quickstarts: https://github.com/salaboy/dapr-spring-boot-docs-examples

cc @artursouza your thoughts ^?

@artursouza
Copy link
Contributor

text looks good to me, so Ill approve - still think we want this in the java-sdk or quickstarts: https://github.com/salaboy/dapr-spring-boot-docs-examples

cc @artursouza your thoughts ^?

Yes, we need them there. It can be a new PR.

@artursouza artursouza merged commit 7dcab0b into dapr:master Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spring Boot integrations Docs

3 participants