Feat Cross App CallActivity

[cicoyle]

Add support for cross app call activity calls.

[cicoyle]

Note, this PR should be cherrypicked into the release branch once merged.

[cicoyle]

This PR is also dependent on the dapr release for 1.16. Javi has a PR to update to the latest rc version here. We will need both merged in, then cherrypick both to the release branch

[cicoyle]

I need to release durabletask-java with this PR merged in before this current PR will be green

[salaboy]

@cicoyle I was looking at this PR, but it doesn't have anything related to cross app call activity.

[cicoyle]

@cicoyle I was looking at this PR, but it doesn't have anything related to cross app call activity.

Did you by chance read the thorough readme updates I added?

[cicoyle]

I just got a workflow IT test locally 🎉 Need to cleanup and push, will do that + fix the conflict in my morning. Please feel free to review everything else and know I will update the pom.xml in my morning and add an IT test. Ill remove the mechanical markdown since Ill be adding the IT test.

[salaboy]

@cicoyle I've left a bunch of comments and suggestions. I am really against adding support for customHttp and customGrpc ports that is something that users shouldn't need to do as that goes against the idea of using containers that are started with random ports, but still allow the user to obtain the mapped ports to connect to them.

[salaboy]

@cicoyle overall the example looks good and the new additions for Cross App Call are good, but I believe that all the changes in the DaprContainer class will cause issues. I am curious to see what are the issues that you are facing if you don't introduce any change in that class.

DaprContainer is a critical class being used by customers now, so I would change the behavior of it.

My recommendation would be to revert the changes on DaprContainer and I can help you to figure out what is going wrong with the containers when the pipelines fail.

[salaboy]

@cicoyle codecov is still failing and sb 3.3.x was cancelled for some reason, I think the changes in the PR are ok if the pipelines and codecov are green.

[cicoyle]

@cicoyle codecov is still failing and sb 3.3.x was cancelled for some reason, I think the changes in the PR are ok if the pipelines and codecov are green.

I pushed a test that should appease codecov. I also upped the test timeout to unblock this PR. I will open an issue to parallelize the test suite a bit bc it should not take this long.

[cicoyle]

created this issue

[artur-ciocanu]

@cicoyle this looks great! I have left some comments. Some of them are nitpicks.

I want to make sure that all the ITs that are using Testcontainers follow the same pattern and we rely on Testcontainer machinery for all the resource bootstrap and cleanup.

I am guessing you have run into issues that's why you added the ensureDependenciesCopied() method, but my question is why can't we have everything done during build, so we don't have to invoke Maven during IT execution.

[javier-aliaga]

@artur-ciocanu @salaboy I fixed all you comments and suggestion, can you take look again?

[salaboy]

LGTM, thanks @javier-aliaga for adding the @containers to the test.. that will simplify our lives

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.89%. Comparing base (d759c53) to head (13921bf).
⚠️ Report is 215 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1468      +/-   ##
============================================
+ Coverage     76.91%   78.89%   +1.98%     
- Complexity     1592     1934     +342     
============================================
  Files           145      237      +92     
  Lines          4843     5952    +1109     
  Branches        562      611      +49     
============================================
+ Hits           3725     4696     +971     
- Misses          821      936     +115     
- Partials        297      320      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.