feat: add jobs #688

atrauzzi · 2025-03-15T22:49:10Z

Description

Added initial support for jobs.

Issue reference

Closes: #667

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

WhitWaldo · 2025-03-16T17:58:49Z

@atrauzzi This runs a linter (for now) as part of the build pipeline and failures will stop the build. Would you mind fixing the lint errors locally and pushing a commit with those changes as well so we can run the checks?

WhitWaldo

Excellent start - still a bit to go, but it's a good foundation.

src/interfaces/Client/IClientJobs.ts

src/interfaces/Server/IServerJobs.ts

src/types/jobs/JobSchedule.type.ts

src/types/jobs/CronExpression.type.ts

WhitWaldo

Coming along - note about the regexps though

src/types/jobs/CronExpression.type.ts

WhitWaldo

More thoughts

src/interfaces/Client/IClientJobs.ts

src/interfaces/Server/IServerJobs.ts

test/e2e/jobs/jobs.test.ts

- Addresses - dapr#688 (comment) - dapr#688 (comment) Signed-off-by: Alexander Trauzzi <[email protected]>

src/types/jobs/CronExpression.type.ts

joebowbeer · 2025-04-19T00:46:46Z

== APP ==     Error: 14 UNAVAILABLE: connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:50001: connect: connection refused"
== APP ==         at callErrorFromStatus (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/call.ts:82:17)
== APP ==         at Object.onReceiveStatus (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/client.ts:360:55)
== APP ==         at Object.onReceiveStatus (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/client-interceptors.ts:458:34)
== APP ==         at Object.onReceiveStatus (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/client-interceptors.ts:419:48)
== APP ==         at /home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/resolving-call.ts:163:24
== APP ==         at processTicksAndRejections (node:internal/process/task_queues:78:11)
== APP ==     for call at
== APP ==         at ServiceClientImpl.makeUnaryRequest (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/client.ts:325:42)
== APP ==         at ServiceClientImpl.invokeService (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/make-client.ts:189:15)
== APP ==         at /home/runner/work/js-sdk/js-sdk/src/implementation/Client/GRPCClient/invoker.ts:64:14
== APP ==         at new Promise (<anonymous>)
== APP ==         at GRPCClientInvoker.invoke (/home/runner/work/js-sdk/js-sdk/src/implementation/Client/GRPCClient/invoker.ts:63:12)
== APP ==         at Object.<anonymous> (/home/runner/work/js-sdk/js-sdk/test/e2e/grpc/server.test.ts:78:21) {
== APP ==       code: 14,
== APP ==       details: 'connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:50001: connect: connection refused"',
== APP ==       metadata: Metadata {
== APP ==         internalRepr: Map(2) { 'traceparent' => [Array], 'grpc-trace-bin' => [Array] },
== APP ==         options: {}
== APP ==       }
== APP ==     }
== APP == 
== APP ==       at Object.<anonymous> (test/e2e/grpc/server.test.ts:81:17)

WhitWaldo · 2025-04-19T10:15:12Z

== APP ==     Error: 14 UNAVAILABLE: connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:50001: connect: connection refused"
== APP ==         at callErrorFromStatus (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/call.ts:82:17)
== APP ==         at Object.onReceiveStatus (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/client.ts:360:55)
== APP ==         at Object.onReceiveStatus (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/client-interceptors.ts:458:34)
== APP ==         at Object.onReceiveStatus (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/client-interceptors.ts:419:48)
== APP ==         at /home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/resolving-call.ts:163:24
== APP ==         at processTicksAndRejections (node:internal/process/task_queues:78:11)
== APP ==     for call at
== APP ==         at ServiceClientImpl.makeUnaryRequest (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/client.ts:325:42)
== APP ==         at ServiceClientImpl.invokeService (/home/runner/work/js-sdk/js-sdk/node_modules/@grpc/grpc-js/src/make-client.ts:189:15)
== APP ==         at /home/runner/work/js-sdk/js-sdk/src/implementation/Client/GRPCClient/invoker.ts:64:14
== APP ==         at new Promise (<anonymous>)
== APP ==         at GRPCClientInvoker.invoke (/home/runner/work/js-sdk/js-sdk/src/implementation/Client/GRPCClient/invoker.ts:63:12)
== APP ==         at Object.<anonymous> (/home/runner/work/js-sdk/js-sdk/test/e2e/grpc/server.test.ts:78:21) {
== APP ==       code: 14,
== APP ==       details: 'connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:50001: connect: connection refused"',
== APP ==       metadata: Metadata {
== APP ==         internalRepr: Map(2) { 'traceparent' => [Array], 'grpc-trace-bin' => [Array] },
== APP ==         options: {}
== APP ==       }
== APP ==     }
== APP == 
== APP ==       at Object.<anonymous> (test/e2e/grpc/server.test.ts:81:17)

What's this in reference to?

joebowbeer · 2025-04-19T10:51:49Z

What's this in reference to?

@WhitWaldo This is the failure from the test run of the previous commit.

However, I don't think it sheds much light. I think the interesting failure is in the scheduler's (Testcontainer) log:

"failed to invoke schedule app job:
  error returned from app channel while sending triggered job to app:
    Post \"http://127.0.0.1:8070/job/test\": EOF"

I suspect this 127.0.0.1 is wrong.

test/e2e/jobs/jobs.test.ts

atrauzzi · 2025-04-24T17:30:07Z

Alright, so a small bit of progress on connectivity between the dapr daemon and the scheduler, but sadly not quite there with things yet.

I'm now running into a timeout scenario where it seems like any attempt to use the client.

dapr-js-sdk testcontainers jest timeout.txt

The code seems to hang when I try to create the job. @WhitWaldo, maybe you can spot something?

test/e2e/jobs/jobs.test.ts

codecov · 2025-07-12T05:43:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d1bf38a) to head (17852f6).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #688   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            6         6           
  Branches         1         1           
=========================================
  Hits             6         6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Alexander Trauzzi <[email protected]>

Removes stale bot + adds me to repo owners for bot actions Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: Alexander Trauzzi <[email protected]>

Signed-off-by: Alexander Trauzzi <[email protected]>

Signed-off-by: Joe Bowbeer <[email protected]> Signed-off-by: Alexander Trauzzi <[email protected]>

Signed-off-by: Alexander Trauzzi <[email protected]>

Signed-off-by: Alexander Trauzzi <[email protected]> # Conflicts: # package-lock.json

Signed-off-by: Alexander Trauzzi <[email protected]>

WhitWaldo

Just want to make sure we've got strong test coverage - reviewed on GitHub, so I can't run a check myself, but if it looks good to you, I'm satisifed.

Also, please remove the gRPC implementations of the Jobs bits. The way I see it, the SDK need only implement one or the other and it's up to the runtime to ensure that there's parity in the APIs. We have no need to expose both and have the developer pick one as that would just be confusing. ~~Rather, you've already got HTTP in place, so let's delete the gRPC side.~~

I flipped these. I'd prefer to keep gRPC and drop HTTP.

WhitWaldo · 2025-08-01T15:39:10Z

src/implementation/Client/GRPCClient/jobs.ts

Frankly, I think the SDK should just pick one or the other - if we've got this implemented via HTTP, I don't know we need to have a stub for gRPC (that itself doesn't work) just because as that can lead to developer confusion.

WhitWaldo · 2025-08-01T15:40:05Z

src/implementation/Server/GRPCServer/jobs.ts

As before - if this is implemented using HTTP, no need to add a gRPC implementation just because.

src/types/BuildNumberRange.ts

WhitWaldo · 2025-08-01T15:42:18Z

src/interfaces/Client/IClientJobs.ts

I think the shape of this has changed in the latest protos - I believe there's an override property now.

src/types/jobs/CronExpression.type.ts

WhitWaldo · 2025-08-01T15:50:51Z

test/e2e/jobs/jobs.test.ts

I'd just generally like to see much better test coverage to prove there are no typos in each of the helper extension implementations.

WhitWaldo · 2025-08-01T15:51:48Z

test/unit/jobs/cron.test.ts

When putting together each of the regex variations, just do a quick pass to make sure any seemingly edge cases are covered.

WhitWaldo · 2025-08-13T21:04:12Z

@atrauzzi Do you have any interest in getting this over the finish line?

atrauzzi · 2025-08-13T22:04:50Z

@WhitWaldo - Yepyep. Sorry, been tight on time in the evenings.

Signed-off-by: Alexander Trauzzi <[email protected]>

atrauzzi · 2025-08-14T01:52:53Z

Alright, further to our discussion this evening, let me know what's happening with the protos and which direction you think we should go with the http and grpc stuff.

I've fixed up the one thing for producing the sorted list of days of the week based on enum or ints and of course added two tests for it 🙂

If you have some specifics for the other details, let me know, but I think once the grpc stuff is resolved, we're in pretty good shape!

WhitWaldo · 2025-08-26T16:11:17Z

I'm good with just implementing the HTTP bits (already done) and just leaving gRPC unimplemented. We can call this out in the documentation that this API is currently only supported when using it in an HTTP context and throw an exception that reflects the same.

Protos should be updated per the recently merged conversation API, so if you can merge with that, I think this should generally be good to go, right?

atrauzzi changed the title ~~feat:~~ feat: add jobs Mar 15, 2025

atrauzzi force-pushed the add-jobs branch from 9d97320 to b0bd1b7 Compare March 15, 2025 22:51

WhitWaldo assigned atrauzzi Mar 16, 2025

WhitWaldo added the area/jobs label Mar 16, 2025

WhitWaldo added this to the v3.6.0 milestone Mar 16, 2025

WhitWaldo requested changes Mar 17, 2025

View reviewed changes

src/interfaces/Client/IClientJobs.ts Outdated Show resolved Hide resolved

src/interfaces/Server/IServerJobs.ts Outdated Show resolved Hide resolved

src/types/jobs/JobSchedule.type.ts Outdated Show resolved Hide resolved

WhitWaldo reviewed Mar 18, 2025

View reviewed changes

src/types/jobs/CronExpression.type.ts Outdated Show resolved Hide resolved

WhitWaldo requested changes Mar 18, 2025

View reviewed changes

src/types/jobs/CronExpression.type.ts Outdated Show resolved Hide resolved

WhitWaldo requested changes Mar 22, 2025

View reviewed changes

src/interfaces/Client/IClientJobs.ts Outdated Show resolved Hide resolved

src/interfaces/Client/IClientJobs.ts Outdated Show resolved Hide resolved

src/interfaces/Server/IServerJobs.ts Show resolved Hide resolved

test/e2e/jobs/jobs.test.ts Outdated Show resolved Hide resolved

atrauzzi added a commit to atrauzzi/dapr-js-sdk that referenced this pull request Mar 22, 2025

Cleaning.

577821a

- Addresses - dapr#688 (comment) - dapr#688 (comment) Signed-off-by: Alexander Trauzzi <[email protected]>

ConstantinChirila reviewed Mar 26, 2025

View reviewed changes

src/types/jobs/CronExpression.type.ts Outdated Show resolved Hide resolved

joebowbeer reviewed Apr 19, 2025

View reviewed changes