Rename wait_until_ready to wait_for_sidecar #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Callarisa <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #843 +/- ##
===============================================
Coverage ? 87.15%
===============================================
Files ? 93
Lines ? 6164
Branches ? 0
===============================================
Hits ? 5372
Misses ? 792
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elena-kolevska
approved these changes
Sep 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
* 1.16.0-rc1 Signed-off-by: Elena Kolevska <[email protected]> * [Conversation API - Alpha2] Add new tool calling capability (#822) (#832) * initial * fixes after proto change upstream * minor name changes and cleanup unused function * refactors, updates to readme, linting * feedback * feedback, updates * fix import in examples * cleanup, import, lint, more conversation helpers * clarify README, minor test import changes, copyright * feedback DRY test_conversation file * lint * move conversation classes in _response module to conversation module. Some example README refactor/lint * minor readme change * Update daprdocs/content/en/python-sdk-docs/python-client.md * lint * updates to fix issue with tool calling helper when dealing with classes instead of dataclasses, and also with serializatin output of the tool back to the LLM * coalesce conv helper tests, fix typing lint * make indent line method doc more dev friendly * tackle some feedback, still missing unit tests * add unit test to convert_value_to_struct * more unit tests per feedback * make async version of unit test conversation * add some information how to run markdown tests with a different runtime * ran tox -e ruff, even though tox -e flake8 was fine * add tests to increase coverage in conversation and conversation_helpers that codecov pointed out * add more information on execute registered tools, also added more tests for them to validate * fix test failing on py 1.13. Merge two unit test files per feedback * Linter * fix typing issue with UnionType in py3.9 --------- Signed-off-by: Filinto Duran <[email protected]> Signed-off-by: Elena Kolevska <[email protected]> Co-authored-by: Albert Callarisa <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> * update docs with tool calling helpers info (#838) Signed-off-by: Filinto Duran <[email protected]> * 1.16.0rc2 Signed-off-by: Elena Kolevska <[email protected]> * use latest durabletask (#840) Signed-off-by: Cassandra Coyle <[email protected]> * 1.16.0 Signed-off-by: Elena Kolevska <[email protected]> * Adds support for interceptors and concurrency_options arguments in the workflow engine (#841) Signed-off-by: Albert Callarisa <[email protected]> * Implement multi-app workflows (#844) * feat: Adds support for cross-app calls. Signed-off-by: Albert Callarisa <[email protected]> * Use durabletask alpha.9 Signed-off-by: Albert Callarisa <[email protected]> * Added examples for error scenarios in multi-app workflow Signed-off-by: Albert Callarisa <[email protected]> * Remove unnecessary hardcoded ports Signed-off-by: Albert Callarisa <[email protected]> --------- Signed-off-by: Albert Callarisa <[email protected]> * chore: Rename wait_until_ready to wait_for_sidecar (#843) Signed-off-by: Albert Callarisa <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> * 1.16.1rc1 (#846) Signed-off-by: Albert Callarisa <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Filinto Duran <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Albert Callarisa <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Co-authored-by: Filinto Duran <[email protected]> Co-authored-by: Albert Callarisa <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Co-authored-by: Albert Callarisa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #820
For consistency with other SDKs, renaming
wait_until_readytowait_for_sidecar.Keeping 'old' method for retro-compatibility, with a deprecation warning.