Open
Conversation
Signed-off-by: Filinto Duran <filinto@diagrid.io>
2f547be to
5e489fa
Compare
alicejgibbons
requested changes
Feb 18, 2025
Contributor
alicejgibbons
left a comment
There was a problem hiding this comment.
@filintod this is great however I believe needs README updates with each of the associated quickstarts as well with instructions to deploy to K8s. For example, for actors we would need to add a new section in the readme "Deploying to k8s" with instructions on how to use dapr --init -k --dev and then we should include deployment.yaml files for each app :)
Lets chat, maybe you and I can split some of this work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When deploying with
dapr --init -k --devwe have a ready to use redis instance but the components in the quickstarts do not reflect this. This adds a new folder with suffix-k8sto add the components that can be used in kubernetes. Another option would be to change the cli to change the values of the local component and push to k8s but it might require more work than needed for now.Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: