refactor query method for Android platform#366
Open
seamlink-aalves wants to merge 2 commits intodariosalvi78:masterfrom
Open
refactor query method for Android platform#366seamlink-aalves wants to merge 2 commits intodariosalvi78:masterfrom
seamlink-aalves wants to merge 2 commits intodariosalvi78:masterfrom
Conversation
Owner
|
the issue I have with this is that onSuccess(data) will be called as soon as the loop has finished iterating on the received data array, with additional queries for distance and calories still pending. Isn't this your experience ? |
Author
|
You are correct. I missed that detail. I've pushed another change to the PR where I wrap the queryAgregate in a Promise and use it with async/await |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored query function to avoid recursion
Closes #365