load contract bytes at runtime in deploy_native_contracts#267
Open
noot wants to merge 1 commit intodarkrenaissance:masterfrom
Open
load contract bytes at runtime in deploy_native_contracts#267noot wants to merge 1 commit intodarkrenaissance:masterfrom
noot wants to merge 1 commit intodarkrenaissance:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using the
drkcrate as a dep in an external repo led to these compilation errors:the relative path used in
include_bytesturned into/src/validator/../contract/money/darkfi_money_contract.wasmwhen darkfi is used as a lib, which is not a valid path.this PR fixes the issue by loading the wasm bytes at runtime, using
CARGO_MANIFEST_DIRto get a nonrelative path.this was tested using a patch as follows +
make clippy: