Merge pull request #19688 from horazont/fix/denoise-highlight-preservation-checkbox

denoiseprofile: handle images w/o highlight preservation metadata better

Author: TurboGit

src/iop/denoiseprofile.c

@@ -2822,6 +2822,20 @@ void init(dt_iop_module_t *self)
   }
 }
 
+static int _get_iso_highlight_preservation_shift(dt_image_t *img)
+{
+  const float hilight_pres = img->exif_highlight_preservation;
+  // Only compensate whole EV steps, as non-whole steps are (based on
+  // experience and discussion in #19624) handled by different means in the
+  // camera.
+  const int shift = floorf(hilight_pres);
+  if(shift <= 0)
+  {
+    return 0;
+  }
+  return shift;
+}
+
 /** this will be called to init new defaults if a new image is loaded
  * from film strip mode. */
 void reload_defaults(dt_iop_module_t *self)
@@ -2842,7 +2856,9 @@ void reload_defaults(dt_iop_module_t *self)
   d->fix_anscombe_and_nlmeans_norm = TRUE;
   d->use_new_vst = TRUE;
   d->wavelet_color_mode = MODE_Y0U0V0;
-  d->compensate_hilite_pres = TRUE;
+
+  const int iso_shift = _get_iso_highlight_preservation_shift(&self->dev->image_storage);
+  d->compensate_hilite_pres = iso_shift > 0;
 
   GList *profiles = dt_noiseprofile_get_matching(&self->dev->image_storage);
   char name[512];
@@ -2983,19 +2999,8 @@ static dt_noiseprofile_t dt_iop_denoiseprofile_get_auto_profile(dt_iop_module_t
   int shift = 0;
   if(compensate_hilite_pres)
   {
-    const float hilight_pres = self->dev->image_storage.exif_highlight_preservation;
-    // Only compensate whole EV steps, as non-whole steps are (based on
-    // experience and discussion in #19624) handled by different means in the
-    // camera.
-    shift = floorf(hilight_pres);
-    if(shift >= 0)
-    {
-      iso >>= shift;
-    }
-    else
-    {
-      shift = 0;
-    }
+    shift = _get_iso_highlight_preservation_shift(&self->dev->image_storage);
+    iso >>= shift;
   }
   dt_noiseprofile_t *last = NULL;
   for(GList *iter = profiles; iter; iter = g_list_next(iter))
@@ -3289,6 +3294,10 @@ void gui_update(dt_iop_module_t *self)
                          !p->fix_anscombe_and_nlmeans_norm);
   gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(g->use_new_vst), p->use_new_vst);
   gtk_widget_set_visible(g->use_new_vst, !p->use_new_vst);
+
+  const int iso_shift = _get_iso_highlight_preservation_shift(&self->dev->image_storage);
+  gtk_widget_set_visible(g->compensate_hilite_pres, iso_shift > 0);
+
   if((p->wavelet_color_mode == MODE_Y0U0V0) && (g->channel < DT_DENOISE_PROFILE_Y0))
   {
     g->channel = DT_DENOISE_PROFILE_Y0;