Moving an image does not include sidecar text file#19160
Moving an image does not include sidecar text file#19160TurboGit merged 4 commits intodarktable-org:masterfrom
Conversation
TurboGit
left a comment
There was a problem hiding this comment.
Some comments, apart from that it works on my side.
|
Just need an entry for the release notes. TIA. |
I am not sure if this minor bugfix is worth mentioning in the release notes. Anyway, I would write something like the following: Is there a place where I could/should add this? |
|
Thanks, I have added this into the RELEASE_NOTES.md (found top of Git repository). And yes it is important to have an entry for fixed issues. Only very marginal issue can be fixed without an entry but here we have a real bug which can dissociate the image from the additional text/audio files. |
|
And again thanks for your first contribution ! |
* copy text and audio file to location of new file * refactoring * add possibility to rename with move * requested changes from review
This is a solution proposal for issue #19097.
I am not sure if the new function _move_extra_file() is acceptable in this way, but I wanted to avoid duplicate coding as much as possible.
The complexity comes from the fact that apparently it is possible to also change the name of an image while moving, at least from a lua script, and the extension for sidecar text and audio file could be in lower or upper case letters. I thought it right to keep the extension.
This is my first attempt to contribute to darktable, so please bear with me, if I made obvious mistakes.