Skip to content

Moving an image does not include sidecar text file#19160

Merged
TurboGit merged 4 commits intodarktable-org:masterfrom
deekayhd:move_image_extra_files
Sep 6, 2025
Merged

Moving an image does not include sidecar text file#19160
TurboGit merged 4 commits intodarktable-org:masterfrom
deekayhd:move_image_extra_files

Conversation

@deekayhd
Copy link
Contributor

@deekayhd deekayhd commented Aug 2, 2025

This is a solution proposal for issue #19097.
I am not sure if the new function _move_extra_file() is acceptable in this way, but I wanted to avoid duplicate coding as much as possible.
The complexity comes from the fact that apparently it is possible to also change the name of an image while moving, at least from a lua script, and the extension for sidecar text and audio file could be in lower or upper case letters. I thought it right to keep the extension.

This is my first attempt to contribute to darktable, so please bear with me, if I made obvious mistakes.

@TurboGit TurboGit added bugfix pull request fixing a bug scope: DAM managing files, collections, archiving, metadata, etc. scope: codebase making darktable source code easier to manage release notes: pending labels Aug 9, 2025
@TurboGit TurboGit added this to the 5.4 milestone Aug 9, 2025
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, apart from that it works on my side.

@deekayhd deekayhd requested a review from TurboGit September 3, 2025 20:32
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
Copy link
Member

TurboGit commented Sep 6, 2025

Just need an entry for the release notes. TIA.

@TurboGit TurboGit merged commit 53e85ec into darktable-org:master Sep 6, 2025
6 checks passed
@deekayhd
Copy link
Contributor Author

deekayhd commented Sep 6, 2025

Just need an entry for the release notes. TIA.

I am not sure if this minor bugfix is worth mentioning in the release notes. Anyway, I would write something like the following:
When moving an image additional extra audio or text sidecar files are now also moved.

Is there a place where I could/should add this?

@TurboGit
Copy link
Member

TurboGit commented Sep 6, 2025

Thanks, I have added this into the RELEASE_NOTES.md (found top of Git repository). And yes it is important to have an entry for fixed issues. Only very marginal issue can be fixed without an entry but here we have a real bug which can dissociate the image from the additional text/audio files.

@TurboGit
Copy link
Member

TurboGit commented Sep 6, 2025

And again thanks for your first contribution !

kofa73 pushed a commit to kofa73/darktable that referenced this pull request Oct 16, 2025
* copy text and audio file to location of new file

* refactoring

* add possibility to rename with move

* requested changes from review
@deekayhd deekayhd deleted the move_image_extra_files branch January 31, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug scope: codebase making darktable source code easier to manage scope: DAM managing files, collections, archiving, metadata, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants