fix paint arrow up/down directions flipped#19242
Merged
Conversation
In `dtgtk_cairo_paint_arrow()` the vertical orientation is flipped: - `CPF_DIRECTION_DOWN` draws an up-arrow - `CPF_DIRECTION_UP` draws a down-arrow
Contributor
|
The whole rotation thing can be simplified as well, as I've done here dterrahe@e9e6f58 EDIT: of course then you'd have to adjust the drawing ( |
Collaborator
Author
|
I just looked for the flipped arrows, didn't look for the code itself. Your solution looks good, why not merge it? |
Contributor
Not a priority. I'd rather see #19118 merged since that is at much higher risk of bit rot. But since you were looking at the same file I thought you might be interested in running with it. |
Collaborator
Author
|
Looks good. I cherry-picked your commit and adjusted the arrow directions in the histogram. They now match their names. |
TurboGit
added
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
dtgtk_cairo_paint_arrow()the vertical orientation is flipped:CPF_DIRECTION_DOWNdraws an up-arrowCPF_DIRECTION_UPdraws a down-arrowSee the histogram where
CPF_DIRECTION_DOWNis used to draw an UP-arrow: