-
Notifications
You must be signed in to change notification settings - Fork 1.2k
WIP: Stop using gtk_main() and related APIs #19563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The master branch failed with the error: so I can't test the code. Shall I open a issue? |
|
We don't have issue with dt_init on master at the moment. Don't understand your comment. Also please do not merge branches into your topic branch. If needed rebase. |
Do you mean the master branch or "the master branch with your code"? Could you explain what the status of this PR is? There seems to be some obviously non-working code in there ( Unfortunately a lot of the activity of porting code requires knowledge of gtk3 and gtk4 and an understanding of the darktable codebase. Simple partial conversions, though on the surface useful and needed, like avoiding direct access to GdkEvent fields, may later on need to be touched again, because we don't even have access to the actual events anymore (or shouldn't try to persist in an approach that upstream gtk finds suboptimal). |
Sorry for confusion. Here are some explain:
As a new contributor, I am not particularly familiar with how the community operates. I apologize for any mistakes I may make. |
Sorry for confusion. Since the issue haven't appear at your device, maybe my environment have some problem? Both master branch and master branch with my change have the same issue. |
Alright, maybe I was a bit impatient. Tomorrow I will close this PR, then carefully review the codebase before submitting the code. I apologize for my misconduct. |
#15920
Maybe I need to use GApplication instead of gtk_main. As a new contributor, please review my code at a early time.