Skip to content

Wayland: add DARKTABLE_HIDE_TITLEBAR_ON_MAXIMIZE to disable HeaderBar for Unite compatibility #19694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+46 −6
Draft

Wayland: add DARKTABLE_HIDE_TITLEBAR_ON_MAXIMIZE to disable HeaderBar for Unite compatibility #19694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5175f7
wayland: prefer server-side decorations; add hide-titlebar-when-maxim…
vtyrtov Nov 8, 2025
39f9d6a
wayland: add DARKTABLE_HIDE_TITLEBAR_ON_MAXIMIZE opt-out of HeaderBar…
vtyrtov Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 46 additions & 6 deletions src/gui/gtk.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ dt_gui_session_type_t dt_gui_get_session_type(void)
: DT_GUI_SESSION_X11;
#elif defined(GDK_WINDOWING_X11)
GdkDisplay* disp = gdk_display_get_default();
retun G_TYPE_CHECK_INSTANCE_TYPE(disp, GDK_TYPE_X11_DISPLAY)
return G_TYPE_CHECK_INSTANCE_TYPE(disp, GDK_TYPE_X11_DISPLAY)
? DT_GUI_SESSION_X11
: DT_GUI_SESSION_WAYLAND;
#else
Expand Down Expand Up @@ -1735,15 +1735,55 @@ static void _init_widgets(dt_gui_gtk_t *gui)
widget = gtk_window_new(GTK_WINDOW_TOPLEVEL);
gtk_widget_set_name(widget, "main_window");
gui->ui->main_window = widget;
/*
* Optional: hint the WM to hide server-side titlebar when maximized.
* Default is OFF to preserve the titlebar for users not relying on
* extensions. Enable to avoid a top gap when an external component
* (e.g. GNOME Unite) hides the titlebar.
*
* Enable via:
* - env: DARKTABLE_HIDE_TITLEBAR_ON_MAXIMIZE=1|true
* - conf: ui/hide_titlebar_on_maximize=true
*
* By default do NOT hide the titlebar on maximize. Enable only when
* explicitly requested via env/config for compatibility with extensions
* such as GNOME Unite. */
gboolean hide_on_max = FALSE;
const char *env_hide = g_getenv("DARKTABLE_HIDE_TITLEBAR_ON_MAXIMIZE");
if(env_hide)
{
if(*env_hide == '1' || g_ascii_strcasecmp(env_hide, "true") == 0)
hide_on_max = TRUE;
else if(*env_hide == '0' || g_ascii_strcasecmp(env_hide, "false") == 0)
hide_on_max = FALSE;
}
if(dt_conf_key_exists("ui/hide_titlebar_on_maximize"))
{
/* config overrides environment */
hide_on_max = dt_conf_get_bool("ui/hide_titlebar_on_maximize");
}
gtk_window_set_hide_titlebar_when_maximized(GTK_WINDOW(widget), hide_on_max);

#ifdef GDK_WINDOWING_WAYLAND
if(dt_gui_get_session_type() == DT_GUI_SESSION_WAYLAND)
{
GtkWidget *header_bar = gtk_header_bar_new();
gtk_header_bar_set_title(GTK_HEADER_BAR(header_bar), "darktable");
gtk_header_bar_set_show_close_button(GTK_HEADER_BAR(header_bar), TRUE);
gtk_window_set_titlebar(GTK_WINDOW(widget), header_bar);
gtk_widget_show(header_bar);
/* Wayland: by default use GtkHeaderBar.
* If hide_on_max is enabled (compat mode for GNOME Unite extension), do NOT use
* HeaderBar and prefer server-side decorations so the WM/extension
* can hide the titlebar and resize correctly. */
if(hide_on_max)
{
/* Use server-side decorations */
gtk_window_set_decorated(GTK_WINDOW(widget), TRUE);
}
else
{
GtkWidget *header_bar = gtk_header_bar_new();
gtk_header_bar_set_title(GTK_HEADER_BAR(header_bar), "darktable");
gtk_header_bar_set_show_close_button(GTK_HEADER_BAR(header_bar), TRUE);
gtk_window_set_titlebar(GTK_WINDOW(widget), header_bar);
gtk_widget_show(header_bar);
}
}
#endif

Expand Down